search

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

No Land-Atmosphere Carbon (CO2 only?) Fluxes in Coupled Model? #163

Open rgknox opened 7 years ago

rgknox commented 7 years ago

Summary of Issue:

As far as I can tell, FATES does not pass the requisite information to the host land model to run coupled with an atmosphere. I think the only deficiencies are carbon from co2 and fire emissions.

I believe that carbon fluxes (as well as all other grid-scale fluxes) are prepared in the call to lnd2atm() during clm_drv(). Prior to lnd2atm(), a grid-scale vector called net_carbon_exchange_grc is filled, and I believe this is the key land-atmosphere (non-fire) carbon flux variable. I don't think fates is sending information to the host model (nep, fire carbon fluxes) that will fill this variable. Can anyone see otherwise?

I think coupled land-atmosphere simulations with FATES is pre-mature right now. But I think we should all be well aware that the fluxes are not even hooked up.

Expected behavior:

net_carbon_exchange_grc(g) should be populated with nep fluxes? fireemis_inst should also be populated with fire fluxes.

Steps to reproduce the problem (should include create_newcase or create_test command along with any user_nl or xml changes):

What is the changeset ID of the code, and the machine you are using:

have you modified the code? If so, it must be committed and available for testing:

Screen output or output files showing the error message and context:

ckoven commented 7 years ago

@rgknox so as discussed in #162, CLM just redefined things to pass NBP as its CO2 flux that it sends to the coupler. fates calculates an NBP and should also pass that to the coupler as well (not NEP, unless the coupler expects a separate fire flux?). when we couple into acme, we should be consistent and keep the correct definitions...

ckoven commented 2 years ago

The thing missing right now is to add in the fire carbon flux to the total land-atmosphere flux term. that variable is: https://github.com/NGEET/fates/blob/master/main/EDTypesMod.F90#L668

rosiealice commented 1 year ago

Is this still a thing? The line in the link seems not to work anymore. I guess it moved somewhere else?

rgknox commented 1 year ago

I suspect this is still an issue.