Closed rgknox closed 7 years ago
Item: Both host models ACME and clm-fates read in the namelist variable use_fates_logging, but I forgot add that to the list of variables passed into fates. For the time being, we can turn logging on and off via the "logging event flag" in the parameter file.
Item: Add new pft dimension'ed parameter carbon to biomass ratio, or carbon fraction, C2B... something that reflects that ratio. In ED2 we used a "C2B" multiplier, which usually was around 2.0. @bchristo mentioned that this parameter deviates from 2.0 and has implications for the hydraulics code. @rosiealice and @ckoven, does a C2B parameter have any bearing on the litter fluxes and how they are broken down?
In case anyone's interested, here's a meta-analysis of sorts on the C2B parameter, which could be used to set PFT-specific values; http://www.mdpi.com/1999-4907/3/2/332
On Wed, Aug 23, 2017 at 12:05 PM, Ryan Knox notifications@github.com wrote:
Item: Add new pft dimension'ed parameter carbon to biomass ratio, or carbon fraction, C2B... something of that reflects that ratio. In ED2 we used a "C2B" multiplier, which usually was around 2.0. @bchristo https://github.com/bchristo mentioned that this parameter deviates from 2.0 and has implications for the hydraulics code. @rosiealice https://github.com/rosiealice and @ckoven https://github.com/ckoven, does a C2B parameter have any bearing on the litter fluxes and how they are broken down?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NGEET/fates/issues/263#issuecomment-324416074, or mute the thread https://github.com/notifications/unsubscribe-auth/AOV4ZoAGdtTtXoFY2jUdxBus-vj7Ykviks5sbGnXgaJpZM4O65Jx .
item: any new parameters derived from #276
from #283, remove slascaler as a parameter and from the file, adjust default slope parameter for diameter to leaf biomass allometry to accomodate the difference and maintain similar results
now that fates has its own dedicated parameter file, and thus every parameter in that file is fates-specific, would it be heretical to suggest deleting the 'fates_' prefix in each parameter?
I see no reason to keep the "fates_" namespace". It might be a hassle to those with tailor made parameter files to change all the names around, but emacs could make the fix in seconds knowing the right commands.
I'm not sure I dislike the 'fates_' thing, in the context of running the model in a HLM it does illustrate that those parameters are only used in fates?
I do like the namespacing a lot. We could expand it some more, to fire, for example...
On Oct 4, 2017 6:35 PM, "Ryan Knox" notifications@github.com wrote:
I see no reason to keep the "fates_" namespace". It might be a hassle to those with tailor made parameter files to change all the names around, but emacs could make the fix in seconds knowing the right commands.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NGEET/fates/issues/263#issuecomment-334327457, or mute the thread https://github.com/notifications/unsubscribe-auth/AMWsQ8wW7olYdyEJ6fvdbsqpT8zRWoW9ks5spCRigaJpZM4O65Jx .
I agree with @rosiealice. On the other hand, the fates parameter names tend to be longer than the HLM parameter names. Would it be helpful to add more information into attributes while shorten the names a little bit?
I don't think we should shorten the descriptive bits. Many of the HLM parameters are rendered very mysterious by shortening. I'd get rid of 'fates_' before doing that, but I think the current naming style is fine, for my 2c.
On Oct 4, 2017 10:04 PM, "Maoyi Huang" notifications@github.com wrote:
I agree with @rosiealice https://github.com/rosiealice. On the other hand, the fates parameter names tend to be longer than the HLM parameter names. Would it be helpful to add more information into attributes while shorten the names a little bit?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NGEET/fates/issues/263#issuecomment-334352968, or mute the thread https://github.com/notifications/unsubscribe-auth/AMWsQyJj_0Io7UIPSl5xt-9EL0weYEZKks5spFVdgaJpZM4O65Jx .
ok, lets keep the fates_ prefixes
ok these changes are all in master now. closing.
In the spirit of keeping a minimal number of backwards incompatible updates to the interface. Lets keep a list of things/features/fixes that should be included in the next update.