search

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
100 stars 92 forks source link

ED_val_grperc should be indexed by pft #4

Closed bandre-ucar closed 8 years ago

bandre-ucar commented 8 years ago

ED_val_grperc is a pft parameter. For all uses, only the first value is currently used in the code via: ED_val_grperc(1) The current params file has all values set to the same value of 0.3 (new unused crops are 0.25).

See: https://github.com/NGEET/ed-clm/commit/b62f50b9810eb4d5fe7c124949e5c768818fc7bc#commitcomment-15433319

rosiealice commented 8 years ago

that's strange. It should almost certainly be indexed by pft... (not 1)

On 13 January 2016 at 15:03, Ben Andre notifications@github.com wrote:

ED_val_grperc is a pft parameter. For all uses, only the first value is currently used in the code via: ED_val_grperc(1) The current params file has all values set to the same value of 0.3 (new unused crops are 0.25).

See: b62f50b#commitcomment-15433319 https://github.com/NGEET/ed-clm/commit/b62f50b9810eb4d5fe7c124949e5c768818fc7bc#commitcomment-15433319

— Reply to this email directly or view it on GitHub https://github.com/NGEET/ed-clm/issues/4.

Dr Rosie A. Fisher

Terrestrial Sciences Section Climate and Global Dynamics National Center for Atmospheric Research 1850 Table Mesa Drive Boulder, Colorado, 80305 USA. +1 303-497-1706

http://www.cgd.ucar.edu/staff/rfisher/