NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
99 stars 92 forks source link

Plant hydraulics failure calculating rhizosphere shells #504

Closed pollybuotte closed 2 years ago

pollybuotte commented 5 years ago

I have a single point case with one active PFT, created with this script create_fates_single_pt.txt This case ran for 100 years with plant hydraulics off. With hydraulics on it fails with this error in the cesm.log:

image

From line 5182 in PlantHydraulicsMod it appears the problem may be zero area in the rhizosphere shells: image

Can anyone suggest reasonable values for the absorbing root radius (currently 0.0001) or specific root length (currently 25) that may cure the problem? Or if the source of the error is elsewhere? Thanks.

xuchongang commented 5 years ago

@pollybuotte, would you please let me know which year does this happen? I think this should not be related to radium and specific root length.

pollybuotte commented 5 years ago

@xuchongang, this happens the first year of the simulation. In this case that was 1979.

JunyanDing commented 5 years ago

I got this error message too. I think the cause of this is there is no plants left at that time. The area in the code is the area of forest cover. In my case, this error either occur in the first year or about 20 yr after.

ckoven commented 5 years ago

@JunyanDing the area being passed here: https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantHydraulicsMod.F90#L1643 isn't the canopy area, its the nominal FATES site area (which is a constant = 1 ha), so this shouldn't be the issue here. Perhaps the root length is becoming a tiny negative number and thus its getting a complex answer in https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantHydraulicsMod.F90#L5182?

In any case, sounds like a thing that needs to be done is to go through and add some conditionals, setting root uptake and or perhaps a high level conditional to set overall plant hydraulic dynamics as zero when the plant coverage gets to be very small?

pollybuotte commented 5 years ago

@JunyanDing I ran a case with prescribed, static stand structure. It successfully made it through the first year, past the July 13 failure date. I'm now running for 50 years. Maybe this will help us track down the problem.

pollybuotte commented 5 years ago

These figures show water content across root shells. It appears the lack of ordering from inner to outer by water content and instances of 0 water are problems. image

@bchristo suggested looking into FillDrainRhizShells. A brief look indicates there may be a problem when dwat_kg=0 and shells do not get ordered according to water content starting on line 2098.

rgknox commented 2 years ago

this seems pretty old and we have changed the hydro code significantly since this post, @pollybuotte feel free to re-open if this issue is still relevant