search

NGEET / fates

repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)
Other
105 stars 92 forks source link

Crown depth in Plant Hydraulics #571

Open jkshuman opened 5 years ago

jkshuman commented 5 years ago

@xuchongang @rgknox I see that crown depth is often set to 0.1m https://github.com/NGEET/fates/blob/3f6749d471e8766a212dd0a2b0c4c95aacd97f65/biogeochem/FatesAllometryMod.F90#L1905-L1925

and then read into Plant Hydraulics. https://github.com/NGEET/fates/blob/3f6749d471e8766a212dd0a2b0c4c95aacd97f65/biogeophys/FatesPlantHydraulicsMod.F90#L439-L441 Is the use of this one value correct? There is another equation in there, but currently commented out. (I am not using hydro at the moment, but wanted to confirm this crown_depth usage.)

glemieux commented 2 years ago

This has been taking care of in SFMainMod, but hasn't been implemented in FatesPlantHydraulicsMod. The code is ready to go, but is commented out currently. This was left out of the original #738 as it would be answer changing.