phenology in EDPhysiologyMod has ubiquitous hard-coding

[rgknox]

Summary of Issue:

The subroutine phenology() has several instances of hard-coded indices and variables. In one case, there is an assumed PFT index.

Example for context:

    !LEAF OFF: DROUGHT DECIDUOUS LIFESPAN - if the leaf gets to the end of its useful life. A*, E*
    if (currentSite%dstatus == 2.and.t >= 10)then  !D*
       !Are the leaves at the end of their lives? !FIX(RF,0401014)- this is hardwiring....
       if (timesincedleafon > 365.0*pftcon%leaf_long(7))then 
          currentSite%dstatus = 1         !alter status of site to 'leaves on'
          currentSite%dleafoffdate = t    !record leaf on date          
       endif
    endif

[rosiealice]

gosh, is that still there? That needs to be reconsidered! I think it can just be replaced by the PFT index in this case.

On 23 May 2016 at 14:38, Ryan Knox notifications@github.com wrote:

Summary of Issue:

The subroutine phenology() has several instances of hard-coded indices and variables. In one case, there is an assumed PFT index. Example for context:

!LEAF OFF: DROUGHT DECIDUOUS LIFESPAN - if the leaf gets to the end of its useful life. A*, E*
if (currentSite%dstatus == 2.and.t >= 10)then  !D*
   !Are the leaves at the end of their lives? !FIX(RF,0401014)- this is hardwiring....
   if (timesincedleafon > 365.0*pftcon%leaf_long(7))then
      currentSite%dstatus = 1         !alter status of site to 'leaves on'
      currentSite%dleafoffdate = t    !record leaf on date
   endif
endif

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/NGEET/ed-clm/issues/65

---

Dr Rosie A. Fisher

Terrestrial Sciences Section Climate and Global Dynamics National Center for Atmospheric Research 1850 Table Mesa Drive Boulder, Colorado, 80305 USA. +1 303-497-1706

http://www.cgd.ucar.edu/staff/rfisher/

[rgknox]

do I see you raising your hand @rosiealice as the noble code warrior who will take on the mantle of truth and bring in the new dawn of phenology?

[ckoven]

if so, wait until i finish off my task of getting rid of the whole phenology GDD infrastructure first...

[rgknox]

ahh, a second code warrior has approached

[xuchongang]

As a reminder that we need to merge our parameter file back to trunk. I will do it next as I am in a P workshop now. After which, charlie could merge to replace new parameters.

Yours Chonggang

On Mon, May 23, 2016 at 4:49 PM, Ryan Knox notifications@github.com wrote:

ahh, a second code warrior has approached

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/NGEET/ed-clm/issues/65#issuecomment-221119189

[rgknox]

thanks @xuchongang, looking forward to getting your work merged in.

[ckoven]

phenology still has issues, but not these anymore. closing.