NGRP / node-red-contrib-viseo

Node-RED nodes OpenSourced by VISEO Technologies
Apache License 2.0
225 stars 83 forks source link

QnA Maker node #103

Open Tellenn opened 6 years ago

Tellenn commented 6 years ago

Hi, for tests purpose I wanted to use the QnA Maker node but after research, it appear that the API called in the node isn't updated.

I've created a pull request for this issue #102

TothiViseo commented 6 years ago

Hello Tellenn,

Thank's for posting this pull request !

It appears from the documentation that the host name is app specific. The node should require that this piece of information is passed as a parameter. You can have a look at the following code example to see what should be passed as a parameter: https://docs.microsoft.com/fr-fr/azure/cognitive-services/QnAMaker/quickstarts/nodejs

Cheers

To-Thi

jbinard commented 6 years ago

Hi Tothi,

Here is a new version of the PR to update the QnA maker node #107

This update involves some breaking changes compare to the previous version (new required field for host and subscription key replaced by the endpoint key). I think it should be shipped in a major update.