ehh... gameball.java is missing some method

[andrewshi98]

import java.awt.Color; import java.awt.Dimension; import java.awt.Graphics; import java.awt.Graphics2D; import java.awt.Graphics2D.; import java.awt.RenderingHints; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import java.awt.geom.; import java.awt.event.*;

import javax.swing.JFrame; import javax.swing.Timer;

public class GameBall {

private int x, y, mvX, mvY, size;

public GameBall(int parx, int pary, int parmvX, int parmvY, int parSize) {
    x = parx;
    y = pary;
    mvX = parmvX;
    mvY = parmvY;
    size = parSize;
}

public void move() {
    x += mvX;
    y += mvY;
}

//Sets
public void setX(int parX) {x = parX;}
public void setY(int parY) {x = parY;} 
public void setmvX(int parmvX) { mvX = parmvX;}
public void setmvY(int parmvY) { mvY = parmvY;}
public void setSize(int parSize) {size = parSize;}

//Gets
public Rectangle2D sigh(){return new Rectangle2D.Double(x, y, size, size);}
public int getSize() {return size;}
public int getCenterY() {return y;}
public int getX() {return x;}
public int getY() {return y;}
public int getmvX() {return mvX;}
public int getmvY() {return mvY;}    

}

//Should be like that

[andrewshi98]

for pong.java, just change g2.fill(gameBall.geteEllipse()); to: g2.fill(gameBall.sigh());

[andrewshi98]

By the way:

change (bCent >= p1Y && bCent < p1Y + ((1/3) * pSizeY)) to (bCent >= p1Y - pSizeY && bCent < p1Y + ((1/3) * pSizeY))

p2 ALSO

[rybla]

Ah thank you! I will implement that

[rybla]

Why should I make gameBall a Rectangle2D though? I think that making it that will make it a draw a rectangle and not a circle (for the gameBall)

[rybla]

And also, I am going to make an edit on the logic of the paddle reflection, for it seems that it changes the y-direction of the ball when it shouldn't. Ill point out the change in my next commit

[andrewshi98]

Ehhhh.... for the shape of the gameball, i make it as a rectangle because i forgot the name of the method to create a circle.....

[AlexBlumer]

A circle is an Ellipse2D with the length and width being the same.

[rybla]

I made an update, but it doesnt work at all yet. I will work on it more later, but I wanted to throw out my collider testing. Maybe you guys can tweak it so that it work right, it should pretty easily

[rybla]

Its in the TestPong (test for a collider method to collisions rather than boundaries)

[andrewshi98]

you didn't put break; after every case

[rybla]

Switches and cases have special syntax

[rybla]

Oh wait i see what you mean

[rybla]

i will fix that

[rybla]

Also guys, try to put your new repositories in the Pong / NGSE_Pong repository so we can have all the pong stuff in one place.

[rybla]

Pong now works! Just a few slightly buggy things to fix in my code. I will check your guys's out tomorrow in apcompsci