search

NGXZS / pe

0 stars 0 forks source link

Error in DG sequence diagram #14

Open NGXZS opened 3 months ago

NGXZS commented 3 months ago

Description

Error in DG sequence diagram userCommand is a method from class Command, not Binbash

Expected:

image.png

Actual: (page 4 of DG)

image.png

soc-pe-bot commented 2 months ago

Team's Response

userCommand is a Command object. It is not a method.

Internally, the Parser calls the constructor of the relevant Command class to create the appropriate Command object. It then returns this object back to BinBash as userCommand. This was omitted from the diagram for the sake of brevity (plus, it wasn't entirely relevant to the purpose of this diagram).

The diagram is accurate.

As this seems like a misunderstanding, we will drop the severity of the bug down to VeryLow.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]