Battery charge limit settings not persisting (also resets when running a game)

Speedy-VonGofast commented 1 year ago

Please confirm

[X] I have searched existing issues and found no duplicate
[X] I will fill this out to the best of my ability

Extra details

[ ] I am using a custom pt_oc.json file
[ ] I am using a custom limits_cache.json file
[ ] I have submitted a log through the PowerTools UI

Expected Behaviour

Enabling persist settings should keep enabled the battery charge and the value slide to the previous state when restarting the Steam Deck or after launching a game.

Actual Behaviour

The battery charge limit resets to disabled when restarting the Steam Deck or when starting a game.

Steps To Reproduce

Enable persist settings
Enable battery charge limit
Restart the Steam Deck

Anything else?

I think this kind of settings should be global and should not revert back to default settings when starting a game.

I was expecting this setting to always persist between games as this doesn't affect the games performances but only for the battery health.

Version

1.3.1

Platform

SteamDeck

OS

SteamOS 3 (Stable)

NGnius commented 1 year ago

This is working as intended, so I'm closing this. All settings are supposed to be tied to the game profile.

If you'd like me to reopen it and switch the label to feature request, let me know.

Speedy-VonGofast commented 1 year ago

Yes I would like to turn this to a feature request please

Le sam. 10 juin 2023, 03:11, NGnius (Graham) @.***> a écrit :

This is working as intended, so I'm closing this. All settings are supposed to be tied to the game profile.

If you'd like me to reopen it and switch the label to feature request, let me know.

— Reply to this email directly, view it on GitHub https://github.com/NGnius/PowerTools/issues/109#issuecomment-1585335970, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR23IRE7F7GQRUPQ55R76TXKPCS5ANCNFSM6AAAAAAY53O4A4 . You are receiving this because you authored the thread.Message ID: @.***>

NGnius commented 1 year ago

Done.

I'll address the challenges with a change like this, to see if anyone has a solution to them:

Currently, everything is associated with a game profile, which makes the persistent toggle reasonably intuitive to use. Changing one setting to not follow that behaviour is confusing and not immediately obvious. I'd like to not explain that behaviour with text in the UI since many setting descriptions are already long. We need a way that'll allow the user to easily guess the correct answer to

How does the battery limit setting behave when I start/finish a game?
How does the persistent profile toggle change how the battery limit setting is saved (or not saved)?

There are also technical challenges, since the whole PowerTools codebase is built around the assumption that anything persistable is part of a game profile. But I don't mind doing a reasonably large refactor to accommodate a different way of doing things if it makes sense.

NGnius / PowerTools