NGnius / PowerTools

Moved to
https://git.ngni.us/NG-SD-Plugins/PowerTools
GNU General Public License v3.0
414 stars 29 forks source link

PowerTools 0.7.0 (dev) can't change any settings after launching EmulationStation #17

Closed outerwinnie closed 2 years ago

outerwinnie commented 2 years ago

Expected Behaviour Settings should't get locked/hang when launching EmulationStation.

Actual Behaviour It seems that PowerTools isn't able to detect what is being played and just says "Menu (Default)" in the "Now Playing" section, it's stuck in that state even if you close it and open another game. This also means that you can't change the settings anymore for some reason and you have to reboot to fix it.

To Reproduce Steps to reproduce the behavior: Just opening EmulationStation.

Screenshots, etc. If applicable, add screenshots to help explain your problem. Please include the log (located at /tmp/powertools.log) if possible. Note: the log is deleted when the device is restarted.

Video (sorry for the crappy quality): https://streamable.com/q1nsxh PowerTools.log

NGnius commented 2 years ago

Thanks for the report! Did you have a per-game profile set for emulation station before this update? If I had to guess, it's probably been corrupted and that's crashing PowerTools. Per-game profile settings are stored in ~/.config/powertools/ with filenames like <app id>.json if you want to try to find and/or delete the one for EmulationStation.

JSYK, that's not the correct log. Logs should start with something like this:

2022-07-04 22:35:45,750 INFO PowerTools v0.7.0-indev https://github.com/NGnius/PowerTools
2022-07-04 22:35:45,750 DEBUG CWD: /home/deck/homebrew/services HOME:/home/deck
2022-07-04 22:35:45,754 DEBUG Read `NAME="SteamOS"
PRETTY_NAME="SteamOS"
VERSION_CODENAME=holo
ID=steamos
ID_LIKE=arch
ANSI_COLOR="1;35"
HOME_URL="https://www.steampowered.com/"
DOCUMENTATION_URL="https://support.steampowered.com/"
SUPPORT_URL="https://support.steampowered.com/"
BUG_REPORT_URL="https://support.steampowered.com/"
LOGO=steamos
[...]
outerwinnie commented 2 years ago

I have deleted all the game profiles that i had, and it doesn't seems to be the problem.

I will leave you here the log, this is the right one? powertools.log

Thanks you for your work!

NGnius commented 2 years ago

Yeah that's the right log now, thanks. That shows an error which is presumably caused by sending too much game metadata to PowerTools when EmulationStation is started. So yeah, deleting per-game profiles wouldn't have fixed it. Feel free to gloat.

Seems like an easy fix for me, I'll try to get that done later today.

NGnius commented 2 years ago

Let me know if that latest dev version works better. I wasn't able to completely reproduce your issue, but I happened across something similar, which I fixed, along with reducing the amount of data sent to the back-end when a new game launches.

outerwinnie commented 2 years ago

Yep, it's fixed! Thanks!

There's another bug. If i have per example a game profile for EmulationStation (SMT Off, Boost Off), when i open the application it applies the settings correctly but sometimes the powertools ui doesn't get updated to represent the changes. It also can happen when you close a game and get back to the menu.

Another video with crappy quality (i don't know how to record the screen in the game mode, sorry): https://streamable.com/vw75oq

Should i open another issue to keep better track of it?

NGnius commented 2 years ago

Oh yeah I noticed something like that while working on it yesterday. I thoight I'd fixed it along with the race condition I found, but apparently not.

Should be a quick fix too, don't worry about making a new issue

NGnius commented 2 years ago

Alright, hopefully that should be fixed now too. Since you've been doing such a good job of testing stuff so far, want to try that fix out too?

outerwinnie commented 2 years ago

Yep, it's fully fixed now! Thanks you so much!