NGnius / PowerTools

Moved to
https://git.ngni.us/NG-SD-Plugins/PowerTools
GNU General Public License v3.0
412 stars 31 forks source link

CPU/GPU frequency limiter are not properly loaded when a Steam Deck game profile is being used alongside #99

Open schM0ggi opened 1 year ago

schM0ggi commented 1 year ago

Please confirm

Expected Behaviour

When two profiles, a persistent PowerTools profile and a Steam Deck game profile, are being used, the CPU/GPU frequency limiter settings in PowerTools should be working properly.

Actual Behaviour

When two profiles, a persistent PowerTools profile and a Steam Deck game profile, are being used, only the CPU frequency limiter setting in PowerTools is respected.

Additionally, if the Steam Deck game profile has the GPU clock setting enabled, only this setting is respected and the CPU frequency limiter setting in PowerTools is ignored.

To get everything working, one has to manually use the "reapply settings" function in PowerTools and, if the GPU clock setting in the Steam Deck game profile is being used, set this value to a different one and back to the original again.

Steps To Reproduce

  1. Start a game
  2. Enable a persistent PowerTools profile with a CPU and GPU frequency limit for this game
  3. Enable a Steam Deck game profile for this game
  4. Close the game
  5. Start the game again

OR

  1. Start a game
  2. Enable a persistent PowerTools profile with only a CPU frequency limit for this game
  3. Enable a Steam Deck game profile for this game and enable the GPU clock setting for this game
  4. Close the game
  5. Start the game again

Anything else?

No response

Version

1.3.1 (Latest stable)

Platform

Steam Deck

OS

SteamOS 3 (Stable)

NGnius commented 1 year ago

Sounds like Steam changed it's behaviour. It used to only override the GPU settings when the GPU frequency override was set in their settings. If Steam is now always overriding the GPU frequency regardless of whether it's set, it may be worthwhile investigating #88 to restore the old behaviour.

In general, I aim for the Steam performance settings to override related PowerTools settings. Currently that should mean that setting TDP limits should override fast/slow PPT values from PowerTools and setting GPU frequency should override GPU min/max from PowerTools. I can't guarantee that behaviour, so I usually just say something vague like "don't set Steam settings and PowerTools settings that could fight", but that doesn't work when even unrelated settings fight...

AndehX commented 1 year ago

I've noticed a similar issue. I have my CPU overclocked to 4000, and TDP set to 20w, which works fine and I can see it in the overlay, but the GPU seems to never go beyond 650~ and this has a negative effect on performance. If I pin the GPU to 1000 in power tools, then performance is normal, but then for some reason it locks the CPU back down to 3500.

NGnius commented 1 year ago

That is almost definitely unrelated. I don't provide support for overclocking, though PowerTools does have the necessary functionality.

AndehX commented 1 year ago

as far as the original issue goes, I can confirm the same thing. power tools will not auto load the custom GPU frequency that you set when you launch a game. You have to manually adjust the frequency to get power tools to "refresh"