search

NHAS / wag

Simple Wireguard 2FA
BSD 3-Clause "New" or "Revised" License
486 stars 27 forks source link

accept port ranges for ExposePorts config #68

Closed marulitua closed 8 months ago

marulitua commented 9 months ago

As discussed at #66

NHAS commented 9 months ago

Hi there!

Thanks for this merge request and the effort you've put in to make this.

My only comment is that having the port range format using the dash (-) rather than : would be better as its consistent with the other places we define ports in wag.

I understand its written like this because iptables --dport takes that as its port range syntax.

And one small comment is I'm away from computer for a bit so will test and merge when I get back.

marulitua commented 9 months ago

Understood will update it

marulitua commented 8 months ago

Hi @NHAS please check when you have time

NHAS commented 8 months ago

Yep will do now

NHAS commented 8 months ago

Sweet looks good and I've just merged it onto the unstable branch. Thanks for all your work!

marulitua commented 8 months ago

Awesome! Many thanks.