search

NHDaly / ApplicationBuilder.jl

[deprecated] Compile, bundle, and release julia software
MIT License
168 stars 15 forks source link

Application destination directory and name #42

Closed aistrych closed 5 years ago

aistrych commented 5 years ago

Why application on Linux is packaged into additional appname/core directories and why application binary name is not appname but the name of Julia file containing julia_main function? I think it makes sense for MacOS platform but not so much on Linux/Windows.

Why the builddir directory is put inside the same directory julia_main function file is located? For example build_app_bundle executed like this:

build_app_bundle("src/App.jl", appname="app", builddir="build")

put build directory inside src one which is not very intuitive I would say.

NHDaly commented 5 years ago

Yeah, if you think that would be better, let's change it! :)

Would you be able to open a PR?

aistrych commented 5 years ago

I think I can. Julia is a relatively new language for me but it's fun so I think I will manage :)

aistrych commented 5 years ago

Small update: I still plan to do that I was just very busy lately. I think I will be able to look on it this weekend.

NHDaly commented 5 years ago

https://github.com/NHDaly/ApplicationBuilder.jl/pull/48/ has addressed all of these concerns! :)

The linux/windows build has been changed to write to $appname/bin/$binary_name. The binary_name defaults to your script's basename, but can be changed via a flag. https://github.com/NHDaly/ApplicationBuilder.jl/blob/896e541a08d06a237124eb2ff35643aa080f933f/src/bundle.jl#L10

The buildpath is now understood to be relative to cwd, as paths usually are on the command line: https://github.com/NHDaly/ApplicationBuilder.jl/blob/896e541a08d06a237124eb2ff35643aa080f933f/src/bundle.jl#L19-L21

https://github.com/NHDaly/ApplicationBuilder.jl/blob/896e541a08d06a237124eb2ff35643aa080f933f/src/bundle.jl#L25

https://github.com/NHDaly/ApplicationBuilder.jl/pull/48/files#diff-c124f08b6e3c986fc3a10e09702f0f01L13

thanks for bringing up these issues @Astrych! :)

NHDaly commented 5 years ago

(I'm next going to unify the mac and linux/windows codebases in https://github.com/NHDaly/ApplicationBuilder.jl/pull/51)

aistrych commented 5 years ago

@NHDaly Oh. I forgot about that issue XD Sorry. Great that you have fixed it!

NHDaly commented 5 years ago

Haha me too tbh. Until I needed to start building for Linux. ;) Thanks! Nathan.

On Wed, Apr 17, 2019, 5:33 AM Astrych notifications@github.com wrote:

@NHDaly https://github.com/NHDaly Oh. I forgot about that issue XD Sorry. Great that you have fixed it!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NHDaly/ApplicationBuilder.jl/issues/42#issuecomment-484011132, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgkEcydRy6Q6NKrvfZCUVy5vKfZrLHIks5vhupvgaJpZM4a7Rai .