Open Baeist opened 9 months ago
After thorough examination of the templates, @bhsi-snm, @Baeist and @ThomasAlscher1991 have come to the following conclusions:
. | DaSSCo Field | Northtec Field | DaSSCo Type | Northtec type | DaSSCo description | Northtec description | Conflict | Proposed change |
---|---|---|---|---|---|---|---|---|
asset_updated_by | update_user | string | string | The name of the Pipeline that updated the asset. This will be picked from the "pipeline_name", sent under update. | Username of the person that updated the asset | We assume both fields mean the same but have different names. | Since both fields track which entity updated the asset, let's change the definition to : "Entity that updated the asset". Also let's harmonize the names, so Northtec should change their name to ours. | |
pushed_to_specify_date | date_asset_finalised | string | date | Who syncs with specify? Asset Service or Pipeline? | Who syncs with specify? Asset Service or Pipeline? | We assume both fields mean the same but have different names. | Rename our field. | |
payload_type | payload_type | list of strings | string | What the asset represents (important for how it is processed and when linking to Specify) | What the asset represents (important for how it is processed and when linking to Specify) | Same names but different types | Since an asset is one (1) digitization of an object, any asset can only have one payload type. So we change our type to Northtec typ | |
restricted_access | restricted_access | boolean/array | list of strings (enumerated) | The problem here is that the use of this field is not clearly defined. | Change the type of this field to enumerated list of strings so we get more information why or to whom it is restricted. |
@PipBrewer We have tried to map metadata fields between NorthTech and our template. We have found the above fields pose the questions @ThomasAlscher1991 has mentioned. Can you please have a look at the above fields and help us by answering the following questions:
@ThomasAlscher1991 @bhsi-snm I think a face-to-face discussion initially would be easier to resolve these conflicts
We need to change the following fields in our metadata file:
Field | Change from | Change to | Comment |
---|---|---|---|
barcode | string | list[str] | Each asset can have multiple specimens each with its own barcode. |
specimen_pid | string | list[Map<barcode, string>] | Speciment pids needs to be mapped to the specimens barcode for each asset |
preparation_type | string | list[str] | An asset can consist of multiple preparation types. They are not mapped since its for the whole asset not the individual specimens. |
For NT it means that preparation_type in their specimen protocol needs to be updated to a list. The rest is fine for them.
@bhsi-snm updates
List where we and NT differ with the metadata json when comparing our ndrive files /integration server model with their documentation.
These are the ones where we are using a string instead of a date object. Recommend that we fix this. Requires using "null" instead of empty "" for fields in the metadata from ingestion client. NT creating events is for their internal book keeping and it totally fine. I believe all of these would create an event for their event list.
NT acknowledges this field in their documentation but has no name field name for it. It is possible they dont need that. Are these the same? "Pushed to specify date" does not exist in NT documentation. Its dates and we should use the correct type.
We are currently treating this as a single entry field. We should update to make it a list of strings. There is a list of accepted names in NT documentation. We need to change to using capitalized letters only. It would be more flexible for us if NT got rid of it being an enum list.
This needs to be a list? Not sure who has the truth here. Currently we are only noting one type though.
This needs to be looked at. NT documentation says its a list of user types.
This is not an issue. It contains the specimen data (multiple if its a multispeciment) for each asset (barcode, speciment_pid, preparation_type, collection and institution).
We are currently not populating this field. NT does not have it. Is it necessary?