search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Punctuation after links #165

Open AngelaFaulding opened 4 years ago

AngelaFaulding commented 4 years ago

This is not urgent.

Who needs to sort the layout of the following tables? The columns need sorting to make the display better. Do I need to do it in Together or is it for James?

https://datadictionary.nhs.uk/attributes/consultant_code.html https://datadictionary.nhs.uk/attributes/general_medical_practitioner_ppd_code.html https://datadictionary.nhs.uk/attributes/private_controlled_drug_prescriber_code.html https://datadictionary.nhs.uk/attributes/doctor_index_number.html https://datadictionary.nhs.uk/attributes/general_dental_practitioner_code.html https://datadictionary.nhs.uk/attributes/general_dental_council_registration_number.html https://www.datadictionary.nhs.uk/supporting_information/organisation_coding_frames.html

rajabr57 commented 3 years ago

5/5 Awaiting feedback from James

AngelaFaulding commented 3 years ago

Discussed with James; this may take a while to fix.

jamesrwelch commented 3 years ago

I've made a fix which hopefully sorts the presentation of the table. Conversion from HTML tables to DITA tables is complicated... this fix will only work for those tables where widths are specified, in percentages, in every cell on the top row. (and where the top row has the same number of cells as every other row). As far as I can see, this fixes all the examples highlighted, with the exception of 'organisation coding frames', where one of the cells in the top row does not have a defined width.

AngelaFaulding commented 3 years ago

Thanks James; they look much better. I will look at Organisation Coding Frames for the next release.

AngelaFaulding commented 3 years ago

Also check Organisation Site Coding Frames and Organisation Data Service Default Codes.

GSChandel commented 3 years ago

@AngelaFaulding to confirm to resolve in July/August Sprint.

AngelaFaulding commented 3 years ago

This will be checked in the August release.

AngelaFaulding commented 3 years ago

Can we remove the tables and point to the ODS pages?

AngelaFaulding commented 3 years ago

I am talking to ODS regarding moving the tables and linking to the ODS information as the tables still don't look right in the September release.

AngelaFaulding commented 3 years ago

Patch created to remove the tables, if reviewed in time it will be incorporated in the November 2021 release.

AngelaFaulding commented 3 years ago

Patch incorporated; to be checked in the November release.

AngelaFaulding commented 3 years ago

These have now been fixed but the Dita display looks odd. The full stop is under the final link on each page, below is an example.

Technical guides: Standards repository guide Miscellaneous .

I have checked Together and the html is correct. Is this a Dita issue or is this similar to issue #44 ?

This happens on the following updated items: https://dduat.dev.dataproducts.nhs.uk/attributes/consultant_code.html https://dduat.dev.dataproducts.nhs.uk/attributes/general_medical_practitioner_ppd_code.html https://dduat.dev.dataproducts.nhs.uk/attributes/doctor_index_number.html https://dduat.dev.dataproducts.nhs.uk/attributes/private_controlled_drug_prescriber_code.html

AngelaFaulding commented 2 years ago

@jamesrwelch is this for when we author in Mauro? If so, I'll put it in Post Migration.

AngelaFaulding commented 2 years ago

To be looked at Post Migration.

AngelaFaulding commented 2 years ago

Also check https://www.datadictionary.nhs.uk/supporting_information/contact_details.html

AngelaFaulding commented 8 months ago

Publication still not being done through Mauro so this issue still exists.