NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Generate DD Change Request DITA output via the Orchestrator #244

Open GSChandel opened 3 years ago

GSChandel commented 3 years ago

A process is required to handle Change Requests. The process will link changes in the Mauro model and published DD.

maxChappell commented 3 years ago

OCC dev work - MS28 (Ontoserver orchestration) and MS26 - change papers. Need to verify if all requirements are captured.

rajabr57 commented 3 years ago

5/5 Discuss with James putting properties at the branch level to collect the front page CR page that is needed and need to know what the output of Mauro is intended to be to use Dita to enable us to generate CR document.

rajabr57 commented 3 years ago

11/5 - Cath and Angela have a call with JW today

rajabr57 commented 3 years ago

24/5 - with JW and then to be tested by AF and CC

AngelaFaulding commented 3 years ago

22/6 - SOW call: MS33 Change Papers (continuation of MS26) due for demo by 16th July 2021.

GSChandel commented 3 years ago

James W to Demo on 12th Aug SoW2004 meeting.

GSChandel commented 3 years ago

From SoW meeting (24th Aug) (MS33) - Changes to be shared with Cath/Angela for their review.

AngelaFaulding commented 3 years ago

31/08 - discussion with James, nothing ready for review yet

AngelaFaulding commented 2 years ago

22/12/21 - meeting with James W 20/12. Plan is to demo in the new year.

AngelaFaulding commented 2 years ago

7/1/22 - James hoping to demonstrate on 10/1/22.

AngelaFaulding commented 2 years ago

11/1/22 - CR demonstration not done on 10/1/22. James is still working on this.

AngelaFaulding commented 2 years ago

James provided a Change Request but the content still needs work. James will continue to work on this.

AngelaFaulding commented 2 years ago

31/1/22 - James will provide an example pdf, which can be sent to Marcus. The styling will be dealt with in #375

AngelaFaulding commented 2 years ago

15/2/22 - James is still working on this.

AngelaFaulding commented 2 years ago

Work Package has been signed off and James continues to work on getting the content correct. He should have a new version to show on 21/2/22

AngelaFaulding commented 2 years ago

James presented latest version on 21/2/22. Further work may be necessary regarding different types of content changes.

AngelaFaulding commented 2 years ago

16/05/22 - work completed by James. Ticket moved.

AngelaFaulding commented 2 years ago

Hi @James Welch . I've just tried to create a CR from the branch I created. It has a work item and a Class. But I got this:

image

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 500, "statusText": "OK", "url": "https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/nhsdd/e5ede3c6-daf1-43ab-b23f-a24cd4f9d5c0/publish/changePaper", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/nhsdd/e5ede3c6-daf1-43ab-b23f-a24cd4f9d5c0/publish/changePaper: 500 OK", "error": {} }

I also tried a CR website preview and got:

image

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 404, "statusText": "OK", "url": "https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/nhsdd/e5ede3c6-daf1-43ab-b23f-a24cd4f9d5c0/publish/dita", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/nhsdd/e5ede3c6-daf1-43ab-b23f-a24cd4f9d5c0/publish/dita: 404 OK", "error": {} }

I guess the error is the same.

jamesrwelch commented 2 years ago

This needs investigation and should be easily fixed before the close of the project

AngelaFaulding commented 6 months ago

21/05/24 - tested this again today and still received an error so needs fixing for testing.

image

AngelaFaulding commented 6 months ago

This issue is just for CR generation, there is separate ticket for preview generation: #432

AngelaFaulding commented 5 months ago

From Peter 21/06/24: I have refreshed the TEST environment again, this only includes two minor changes:

  1. Fix for generating of change papers using the orchestrator.

24/06/2024 - this still isn't working.

image

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 504, "statusText": "Gateway Time-out", "url": "https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/73e608ef-244a-4292-919d-75f366dafbf1/publish/changePaper", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/73e608ef-244a-4292-919d-75f366dafbf1/publish/changePaper: 504 Gateway Time-out", "error": {} }

pjmonks commented 5 months ago

@AngelaFaulding I've created a bug for us to track the issue of the change paper publish not completing, this may be fixed by us adjusting the test environment itself rather than a Mauro issue.

AngelaFaulding commented 5 months ago

We can't test the inflight branches until this is fixed.

AngelaFaulding commented 4 months ago

1/7/24 - this still isn't working:

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 504, "statusText": "Gateway Time-out", "url": "https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/8006913a-4543-4e51-8321-a54db28ad21c/publish/changePaper", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/8006913a-4543-4e51-8321-a54db28ad21c/publish/changePaper: 504 Gateway Time-out", "error": {} }

pjmonks commented 4 months ago

That might be because we haven't worked on fixing it yet, it is in progress. I will report back when it is good to test again.

Please refer to:

AngelaFaulding commented 4 months ago

I have run the CRs CR1915 and CR1903 successfully

For CR1883, I got this:

image

pjmonks commented 3 months ago

Test environment release 9 on 08/08/2024 has updated the change paper DITA generation, please test this again.