NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Testing of Migration of Work in Progress Branches #291

Open GSChandel opened 3 years ago

GSChandel commented 3 years ago

Definition of Done - End to end testing of the migration of individual branches (few selected to ensure the approach works and any issues picked up) and get it approved by the product owner (Nicholas O.) and the customer (Cath C.).

maxChappell commented 3 years ago

First test failed. Reasons to be discussed and options to take next on Likin's return from leave.

maxChappell commented 3 years ago

Minor code tweaks needed to the knitting application to make this work. Will need to test that Mauro checks for pre-existing fhir items at merge.

AngelaFaulding commented 2 years ago

22/12/21 - CR1736 being tested by James and being helped by Likin

AngelaFaulding commented 2 years ago

James tested branch ingest 10/12/21. Encountered one issue which has been referred to Likin to investigate the reason the for error. The item had not been edited in the branch.

AngelaFaulding commented 2 years ago

Likin is going to retest CR1736, Revision 767.

likin1 commented 2 years ago

I had a meeting with Maxine today regarding the issue and it seems that this is a not an issue from my side. Though there will be some work required from James to handle this. Maxine , James and I will get on a call on 26th Jan to discuss this.

rajabr58 commented 2 years ago

Discussed at call with JW and Maxine on 26th. Rachel to raise a JIRA ticket for this work and put into backlog for discussion at next sprint.

likin1 commented 2 years ago

Figured out the root cause of the issue. It was because of the wrong cannonical url in some cases. Fix has been applied will generate the valueset xml.

rajabr58 commented 2 years ago

Hi Likin

Can this ticket be closed now?

Rachel

Rachel Brown

AngelaFaulding commented 2 years ago

This ticket will stay open as James needs to process the branch to produce Dita. It then needs to be run through Oxygen.

AngelaFaulding commented 2 years ago

28/1/22 - branch migration discussed on the Oxford call. There are issues with the branch so a further test is required. The new test branch is CR1818: revision number 779.

Details relating to National Codes and Default Codes:

Updated Attribute: APPOINTMENT TYPE FOR IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES 1 National Code retired (07) 2 new National Codes (10 and 98)

Associated Data Element: APPOINTMENT TYPE (IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES) 1 retired Default Code (08) 1 new Default Code (99)

New Attribute: SOURCE OF REFERRAL FOR IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES New National Codes: (A1, A2, A3, A4, B1, B2, C1, C2, C3, D1, D2, E1, E2, E3, E4, E5, E6, F1, F2, F3, G1, G2, G3, G4, H1, H2, I1, I2, M1, M2, M3, M4, M5, M6, M7, M8, N1, N2, N4, P1, Q1)

Associated Data Element: SOURCE OF REFERRAL FOR IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES No Default Codes

New Data Element: ONWARD REFERRAL REASON (IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES)
No new attribute as it is linked to existing attribute New Default Codes (98 and 99)

Retired Attribute: SOURCE OF REFERRAL FOR MENTAL HEALTH Retired associated Attribute: SOURCE OF REFERRAL FOR MENTAL HEALTH

Retired Data Elements: JOBSEEKERS ALLOWANCE RECEIPT INDICATOR OTHER BENEFITS RECEIPT INDICATOR (IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES) Both linked to Attribute BENEFIT RECEIPT INDICATOR FOR IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES. This attribute remains and is linked to other Data Elements.

AngelaFaulding commented 2 years ago

31/1/22 - @likin1 - as discussed with Maxine on Migration Planning, can you please pull this branch as soon as possible as it will be incorporated into the trunk in the next week.

maxChappell commented 2 years ago

Copy of branch taken by Likin - free to merge

AngelaFaulding commented 2 years ago

Thanks @maxChappell and @likin1 - I will incorporate the branch.

AngelaFaulding commented 2 years ago

Comments regarding incorporation are not relevant to the issue. They were just information sharing between Maxine, Likin and I.

rajabr58 commented 2 years ago

Confirmation from Maxine that output was sent to James by Likin

GSChandel commented 2 years ago

James W - Still waiting for the updated branch from Likin. The last updated branch sent was in Nov'21.

rajabr58 commented 2 years ago

The output that was originally sent to JW had a defect so needs to be repeated but Likin to discuss in first instance with Maxine next week when she returns from leave

maxChappell commented 2 years ago

Meeting held between Likin, James and Maxine on 10/03/22. Technical approach agreed. Likin to generate a new test file - run against November 21 release

rajabr58 commented 2 years ago

New test file sent to James on Tues 15th

jamesrwelch commented 2 years ago

Ingested content into Mauro - at first glance this looks ok, but need to check the flags on the retired codes. Then will generate a change paper PDF to ensure all differences are correctly captured.

jamesrwelch commented 2 years ago

Ok, yes, so one minor issue I've spotted - there are some coded values which have been retired in this release but still have

<property>
   <code value="Status"/>
   <valueString value="active"/>
</property>

in the xml. Examples of this are in the attribute 'APPOINTMENT TYPE FOR IMPROVING ACCESS TO PSYCHOLOGICAL THERAPIES' and its associated element: 'APPOINTMENTTYPE(IMPROVING_ACCESS_TO_PSYCHOLOGICAL_THERAPIES)'

@likin1 Are you able to take a look, please?

rajabr58 commented 2 years ago

Likin on leave until the 19th April

rajabr58 commented 2 years ago

Likin has other higher priority work that he is assigned to at the moment but he is hoping to look at this again sometime this week.

likin1 commented 2 years ago

Hello @jamesrwelch. I had fixed this issue straight away when it was reported. This issue will not appear when we run any branch in the future. Regards Likin Gera

AngelaFaulding commented 2 years ago

Do we now need to test this on another branch? Gouri asked if this ticket can be closed. It can't be closed until we are sure that all branches will be migrated successfully. Can we discuss this on the Oxford call 17/05/22.

AngelaFaulding commented 2 years ago

16/05/22 - checked with James his understanding of this issue. He explained the conversation he had with Likin in March, see below. James is waiting for the updated file to test. Rachel to check whether Likin can send it immediately or if there will be a delay. image.

AngelaFaulding commented 2 years ago

This ticket can't be closed until we have tested a branch through the full process, including the DDPM. We need to be sure that the output from Mauro and the DDPM matches the CR produced via Together and POSH.

likin1 commented 2 years ago

Hi @jamesrwelch . Please find attached the updated xml 291_branch_779.zip

rajabr58 commented 2 years ago

@GSChandel - as per update from Likin, the updated file has now been sent to James

jamesrwelch commented 2 years ago

I've just looked through the generated file - thanks @likin1 . It's mostly correct, but we may need another chat about the approach - my understanding is that Likin would re-use his existing code to sort out the codes for attributes and data elements. Looking at Attribute "APPOINTMENT_TYPE_FOR_IMPROVING_ACCESS_TO_PSYCHOLOGICAL_THERAPIES", however:

If this is the intention, that's fine, I can write some code to process items that have changed, but I believe these are things that Likin already does in his pipeline as part of a normal release. Happy to discuss on this thread or on a call.

AngelaFaulding commented 2 years ago

8/7/22 - I spoke to Bob to clarify the situation with Likin. Work is progressing on the pipeline. He is working on the internal proof of concept. Likin is not available to work on any tickets until this work is complete. This could be November as that is when the next dictionary release is due. Bob says if Likin is distracted it could affect dictionary publication. Bob will obviously let us know if this changes.

AngelaFaulding commented 3 months ago

21/05/24 - testing for this needs to start as soon as Mauro testing has commenced as there were issues with the Mauro output last time. Gouri and Steve have this on their plan for Data Solutions.

AngelaFaulding commented 3 months ago

3 inflight branches sent to Likin for testing 10 June 2024:

AngelaFaulding commented 2 months ago

Branches have been imported into Mauro. Work item information needs adding before they can be tested.

AngelaFaulding commented 2 months ago

We can't test these yet as we are able to generate a CR, see #244

AngelaFaulding commented 1 month ago

See #244 and #432. I have run the CRs and previews for CR1915 and CR1903 successfully but neither has worked for CR1883. Why is this?

pjmonks commented 1 month ago

Test environment release 9 on 08/08/2024 has updated the DITA generation, please test this again.

AngelaFaulding commented 3 weeks ago

This is being done by Steve and @NellySSJ