Stylesheet update for new CRs generated via Mauro

NHSDigital / DataDictionaryPublication

Apache License 2.0

7 stars 1 forks source link

Stylesheet update for new CRs generated via Mauro #308

Open AngelaFaulding opened 2 years ago

AngelaFaulding commented 2 years ago

When CRs are generated via Mauro the stylesheet for CRs needs updating to include NHS styling, e.g. NHS Logo, ISO Logo.

AngelaFaulding commented 2 years ago

Meeting with Marcus today. He will help when we have dita from Oxford and I have tested via Oxygen.

AngelaFaulding commented 2 years ago

CR Dita has been provided by James. I have tested it in Oxygen. James is going to do some work on the stylesheet before I speak to Marcus.

AngelaFaulding commented 2 years ago

Call held 3/2/22 with James, Cath, Angie and Marcus. Further meeting with James and Marcus planned for 8/2/22.

AngelaFaulding commented 2 years ago

James met with Marcus 8/2/22 and has a few changes to make. James will provide a further example when he has made the changes.

AngelaFaulding commented 2 years ago

15/2/22 - James is still working on this and will provide a further example when he has made the changes.

AngelaFaulding commented 2 years ago

James to generate CR1818 for us to look at.

AngelaFaulding commented 2 years ago

There is an issue with strikethrough that we were going to discuss with Cath but she has recently been unavailable for Mauro meetings. This will need addressing if the project restarts.

AngelaFaulding commented 4 months ago

Steve has said that Data Solutions will be responsible for this so he needs to ensure it is documented in their work package.

AngelaFaulding commented 3 months ago

Steve is now working on the Stylesheets. A draft CR has been produced by Likin. It has been referred to Steve with

What was generated for the same CR in Together
A CR from before the project was paused a couple of years ago.

We seemed to have taken a step backwards on this.

It may be time to review the styling moving forward as this is a new product.

jamesrwelch commented 3 months ago

Why do you say we have gone backwards? The stylesheets I wrote 2 years ago are in this repository: https://github.com/NHSDigital/DITAStyleSheets

AngelaFaulding commented 3 months ago

1915-16-07-2024.pdf This is what was produced by Likin. I just wanted to make the point that this isn't as good as we had before. Steve is working on this.

jamesrwelch commented 3 months ago

Likin just needs to use the 'NHS Data Dictionary (CR pdf).opt' template in the configuration when he generates the PDF.

AngelaFaulding commented 3 months ago

Sorry James, I have told Steve that. He wants to deal with it.

AngelaFaulding commented 3 months ago

I have advised Steve that a couple of changes are required to the stylesheet:

Replace the NHS Digital logo with the NHS logo (this is what we have on the current CRs)
Remove the ISO logo as NHS England have withdrawn from ISO.

Also, a discussion is required with Nick and Naresh on the styling. Is the new CR fit for purpose?

stevebowring commented 1 month ago

Peter has identified a potential solution to the missing strikethrough issue. Steve & Likin to review & test the code before implementing in our CSS/LESS stylesheets.

stevebowring commented 1 month ago

Likin to run a DITA file with 'diff-html-removed' and 'diff-html-new' - run without changes then,

Likin to put the code into the Less file, then convert into CSS and run the same DITA to check formatting works.

Using CR1915 for comparison.

Steve to update Specification.