search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

“Class Relationships” integrity check doesn’t take account for sub-types #419

Open PaulChapmanPM opened 2 years ago

PaulChapmanPM commented 2 years ago

“Class Relationships” integrity check doesn’t take account for sub-types

AngelaFaulding commented 2 years ago

There are currently 29 relationship failures in each branch: image These are sub types so need removing before we migrate.

AngelaFaulding commented 2 years ago

I don't think this is fixed as there are still 29 issues: image

jamesrwelch commented 2 years ago

This will work on any of the DD versions that I've previously imported. It won't work on the existing branches because of a branching issue which is now resolved. It will work on any new branches created, and when we re-create the test branches, it'll work on those too.

AngelaFaulding commented 2 years ago

Will be tested when we have new models / branches.

AngelaFaulding commented 2 years ago

I checked the March 2022 release and there is now only one that has failed: image

@jamesrwelch - this looks the same in Together as other similar items such, Nurse and Midwife. Do you have any idea why this has failed?

Now the failures have reduced from 29 to 1, I am happy to say this is fixed. We just need to understand how to fix OPTOMETRIST. I will speak to James about this.

AngelaFaulding commented 2 years ago

Checked with James and this should be OK in the July release.