Generate branch previews DITA output via the Orchestrator

NHSDigital / DataDictionaryPublication

Apache License 2.0

7 stars 1 forks source link

Generate branch previews DITA output via the Orchestrator #432

Open AngelaFaulding opened 2 years ago

AngelaFaulding commented 2 years ago

Kun has asked me for Dita generated files for a CR (for pdf) and preview to test in his pipeline. I have generated the CR and preview for CR1818 and appear to have the same files for both. @jamesrwelch , I mentioned this before on my test branch and you were going to investigate.

Two questions:

Is the output correct, both files are 595KB, which seems strange?
Why is the output CRXXXX, not CR1818?

jamesrwelch commented 2 years ago

Yes - I will have this fixed for the next release - for some reason the two buttons are both talking to the same back-end endpoint.
The name of the file is taken from the WorkItem profile, which is not currently populated for that branch. CRXXXX is the default if no value has been set.

AngelaFaulding commented 2 years ago

Thanks @jamesrwelch Does this need to go in "Waiting for Deployment" or "To Do"? Does it need a T shirt label?

AngelaFaulding commented 2 years ago

Same problem as #244 so cannot be tested.

AngelaFaulding commented 6 months ago

21/05/24 - tested this again today and still received an error so needs fixing for testing.

AngelaFaulding commented 6 months ago

This issue is just for preview generation, there is separate ticket for CR generation: #244 This will also mean that the release cannot be generated.

AngelaFaulding commented 4 months ago

1/7/24 - unable to generate a preview

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 504, "statusText": "Gateway Time-out", "url": "https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/8006913a-4543-4e51-8321-a54db28ad21c/publish/website", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://ec2-13-42-94-180.eu-west-2.compute.amazonaws.com/api/nhsdd/8006913a-4543-4e51-8321-a54db28ad21c/publish/website: 504 Gateway Time-out", "error": {} }

AngelaFaulding commented 4 months ago

I have run the preview for CR1915 and CR1903 successfully

For CR1883, I got this:

pjmonks commented 3 months ago

Test environment release 9 on 08/08/2024 has updated the change paper DITA generation, please test this again.

AngelaFaulding commented 2 months ago

I have tried to run the dita file for the newly ingested CR1915 and get this error:

{ "headers": { "normalizedNames": {}, "lazyUpdate": null }, "status": 500, "statusText": "OK", "url": "https://mauro.dev.dataproducts.nhs.uk/api/nhsdd/cdeb7f87-a3f8-48da-ac09-05e5665dbe13/publish/website", "ok": false, "name": "HttpErrorResponse", "message": "Http failure response for https://mauro.dev.dataproducts.nhs.uk/api/nhsdd/cdeb7f87-a3f8-48da-ac09-05e5665dbe13/publish/website: 500 OK", "error": {} }

AngelaFaulding commented 2 months ago

This has been fixed and needs deploying.

pjmonks commented 2 months ago

This issue has been fixed and deployed to TEST, TRAINING and LIVE. Please move this to the "Ready for NHS E Testing" state.

pjmonks commented 2 months ago

The fix was to use the correct DITA library version. To test, simply verify you can create a change paper preview or DITA file.

AngelaFaulding commented 2 months ago

I have now been able to run CR dita files through the Orchestrator:

I have run 2 previews through the Orchestrator: