search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Incorrect National Code description - descriptions going over 2 lines #44

Open jamesrwelch opened 4 years ago

jamesrwelch commented 4 years ago

DIAGNOSIS_SCHEME_IN_USE

FINDING_SCHEME_IN_USE

OBSERVATION_SCHEME_IN_USE

PROCEDURE_SCHEME_IN_USE

SITUATION_SCHEME_IN_USE

maxChappell commented 4 years ago

Hyperlinks in code descriptions not correctly extracted for ontoserver (we just want the label).

Note to likin - on db this appears as a retired codesystem..it isn't for current dd

maxChappell commented 4 years ago

See #27 re hyperlinks in code descriptions

maxChappell commented 4 years ago

Same issue as #65

maxChappell commented 4 years ago

alias="shortname"

maxChappell commented 4 years ago

alias="shortname" = Data_Dictionary_Profile_x__y_DD_Alias_x__y_aliasShortName

maxChappell commented 4 years ago

We need to make sure that fhir generation processes the de-referenced txaclass files in order to fix this once

maxChappell commented 4 years ago

Note also that the special character handling needs to be applied in order for the descriptions to work with ontoserver/fhir - look at diagnosis scheme in use (registered mark for code 06

details on #74

AngelaFaulding commented 4 years ago

Links are now in the descriptions. The descriptions go onto 2 lines. It's no longer a showstopper but needs investigating.

AngelaFaulding commented 4 years ago

October release checked, the descriptions still go onto 2 lines.

AngelaFaulding commented 3 years ago

James to investigate if it can be fixed in the June release

AngelaFaulding commented 3 years ago

This hasn't been fixed in the June release. For example, DIAGNOSIS SCHEME IN USE still has: 04 - Read Coded Clinical Terms Version 2

05 - Read Coded Clinical Terms Version 3 (CTV3)

GSChandel commented 3 years ago

This to be picked up for August release.

AngelaFaulding commented 3 years ago

September output checked, e.g. DIAGNOSIS SCHEME IN USE and the text is still on two lines. @jamesrwelch you mentioned this may be only be resolved when we start authoring in Mauro, is that still correct?

AngelaFaulding commented 3 years ago

24/9 - James is going to look at this for the next sprint.

AngelaFaulding commented 3 years ago

This hasn't been fixed in the November 2021 release.

AngelaFaulding commented 2 years ago

@jamesrwelch is this for when we author in Mauro? If so, I'll put it in Post Migration.

AngelaFaulding commented 2 years ago

This will have to be looked at Post Migration.

AngelaFaulding commented 2 years ago

This may have been fixed as a result of another issue. To be checked after changes have been deployed.

AngelaFaulding commented 2 years ago

Should this work in the preview as currently it doesn't, e.g.

https://www.datadictionary.nhs.uk/attributes/diagnosis_scheme_in_use.html

image

https://www.datadictionary.nhs.uk/attributes/finding_scheme_in_use.html

image

Other scheme in use items don't display correctly: OBSERVATION SCHEME IN USE, PROCEDURE SCHEME IN USE, SITUATION SCHEME IN USE

jamesrwelch commented 2 years ago

I have a fix for this which I'll deploy later today..

Screenshot 2022-08-11 at 10 50 04

.

AngelaFaulding commented 2 years ago

Looks OK in the Orchestrator:

image

We will need to be check this on the website at the next release.

AngelaFaulding commented 2 years ago

@jamesrwelch - these still don't look right:

AngelaFaulding commented 2 years ago

This is fixed in the Mauro pipeline but not in the Meta Data Catalogue. James could upgrade next year to publish in Mauro which will fix this.

AngelaFaulding commented 1 year ago

@jamesrwelch - is there any update on publishing via Mauro as we have had a query why codes go onto 2 lines?

AngelaFaulding commented 1 year ago

These look better, e.g.

AngelaFaulding commented 7 months ago

Publication still not being done through Mauro so this issue still exists.