NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Unable to delete unwanted branch #442

Open AngelaFaulding opened 2 years ago

AngelaFaulding commented 2 years ago

I created a branch as a test but no longer needed it so tried to delete it. I received the following error:

Server Error

We're sorry, but the server responded with an error message.

Details

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 502,
  "statusText": "Proxy Error",
  "url": "https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/versionedFolders/1a111946-0e26-4a89-9c3f-388c13d415fd?permanent=true",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/versionedFolders/1a111946-0e26-4a89-9c3f-388c13d415fd?permanent=true: 502 Proxy Error",
  "error": "<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>502 Proxy Error</title>\n</head><body>\n<h1>Proxy Error</h1>\n<p>The proxy server received an invalid\r\nresponse from an upstream server.<br />\r\nThe proxy server could not handle the request<p>Reason: <strong>Error reading from remote server</strong></p></p>\n</body></html>\n"
}

It wouldn't delete so I marked it as deleted so it wouldn't cause confusion and it is now crossed out. James advised we should be able to delete an unused branch and would look into it.

AngelaFaulding commented 2 years ago

@jamesrwelch - I tried to delete the branch I created on Friday and got this:

Server Error

We're sorry, but the server responded with an error message.

Details

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 502,
  "statusText": "Proxy Error",
  "url": "https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/versionedFolders/882ebedd-796a-4d06-a74b-1279b6f44ed0?permanent=true",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/api/versionedFolders/882ebedd-796a-4d06-a74b-1279b6f44ed0?permanent=true: 502 Proxy Error",
  "error": "<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\n<html><head>\n<title>502 Proxy Error</title>\n</head><body>\n<h1>Proxy Error</h1>\n<p>The proxy server received an invalid\r\nresponse from an upstream server.<br />\r\nThe proxy server could not handle the request<p>Reason: <strong>Error reading from remote server</strong></p></p>\n</body></html>\n"
}

I can't accept this until it is working as accepted

AngelaFaulding commented 2 years ago

It had been deleted when I logged out and logged in again but obviously this needs improving as with #446

AngelaFaulding commented 2 years ago

James agreed that we can't accept this as it is not working correctly and agreed that I would move it back to In Progress.

jamesrwelch commented 2 years ago

New code for branch creation and deletion is in progress in a separate branch of the mdm-core code.

AngelaFaulding commented 6 months ago

This is now fixed and needs retesting.

AngelaFaulding commented 4 months ago

I am now able to delete an unwanted branch.