NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Change Request pdf generation #469

Open AngelaFaulding opened 9 months ago

AngelaFaulding commented 9 months ago

An issue has been raised with the current pdf generation of Change Requests. A CR was unable to be published on the website as the file size was 21,814 KB. There has never been an issue in the past with uploading CRs so I investigated the reason. It appears that the CR generation does not like Chrome or Edge. The problems have arisen since IE was removed from our machines. The publishing plugin was written with use with IE. We are now using the “Internet Explorer mode” to generate CRs and this reduced the size of the file to 2318 KB, so it could be published.

We need to ensure that when the output from Mauro is converted to pdf via Oxygen that we don't have the same issue with the file size. James did have a look at a CR generated through Mauro and the file size seemed bigger than he expected.

jamesrwelch commented 9 months ago

The test file of 25 pages was 451Kb, so we're actually in the right sort of ballpark. But definitely worth keeping in mind and having PDF file size as an acceptance criteria

AngelaFaulding commented 9 months ago

Thanks James, that is good to know. The one we had issues was was 400 pages long but that is unusual. We do need to check during testing.