search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Duplicate Items #489

Open AngelaFaulding opened 1 month ago

AngelaFaulding commented 1 month ago

I created an Attribute Terminology for "PERSON STATED EYE COLOUR THE SAME INDICATOR" and I think I must have clicked twice on Submit Terminology as my machine is slow this morning. There are now two Attribute Terminologies. This seems strange as I would expect that you shouldn't be able to create an item with the same name in a folder. If we are doing a lot of authoring this could happen. I obviously can delete one of the terminologies but want to check this first. Should we be prevented form creating the same item twice?

image

I didn't release this until I tried to create a Term and got an error message:

image

pjmonks commented 1 month ago

You are correct, this should not be possible. I would have expected Mauro to validate that another terminology of the same label exists, but due to the timing of both creation requests perhaps this was not possible.

There is a simple fix we can perform on the UI to prevent this from happening which I have created an issue for. It is low priority, but we will get to it:

For now I would suggest deleting the duplicate and continue adding terms to the remaining terminology.

pjmonks commented 1 month ago

This has been fixed and release to the test environment.