search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Integrity Check failures: Elements linked to an attribute #523

Open AngelaFaulding opened 1 month ago

AngelaFaulding commented 1 month ago

Previously there were no "Elements linked to an attribute" Integrity Check failures, as per the first screen shot below.

When I ran the Integrity Check today, the number of failures was 2698, as per the second screen shot below.

I'm not sure why the number is so high. Has the ingest of the Attribute links not worked?

I have checked ABDOMINAL X-RAY PERFORMED REASON in Mauro and there is no Linked Attribute, as per the third screen shot below.

image

image

image

pjmonks commented 4 weeks ago

We do not know why there are no data elements and attributes linked together, we need to investigate. See:

AngelaFaulding commented 3 weeks ago

19/08/24 - System are working on this.

AngelaFaulding commented 1 week ago

System C are still working on this.

pjmonks commented 6 days ago

I have located the issue, but unfortunately it is not something that System C can fix, this will have to be raised to the Mauro team (@jamesrwelch) as I believe it stems from Mauro's core system.

When testing on your current branches in TEST, I've noticed that:

  1. Any branch I have ingested (released e g. "August 2024" or the in-flight branch "CR1915") has no issues with linked Elements/Attributes. The integrity checks pass on these branches, and the previews for Elements/Attributes show their linked alternative:

image

image

  1. But any branch that has been created entirely in Mauro from one of these branches does not have any linked Elements/Attributes. The integrity check fails, and the previews show nothing:

image

image

The reason I believe is down to what Mauro calls semantic links. In an ingested branch, dictionary items have links to other items automatically added:

image

But when these branches act as the base for the next working draft branch (trunk or CR), these links then appear to get lost, losing the relationships between Elements/Attributes:

image

(The only remaining semantic link is back to itself, for some reason)

This must be happening during the branch creation in Mauro. This has many layers to it due to the various item types it supports, and would need investigating with the Mauro team whether this is working correctly. This is why I think it is out of scope for System C.

AngelaFaulding commented 2 days ago

@jamesrwelch hopes this an easy fix but will investigate.