NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

BRAIN INJURY DETECTED ON MRI SCAN INDICATOR #536

Open AngelaFaulding opened 3 months ago

AngelaFaulding commented 3 months ago

BRAIN INJURY DETECTED ON MRI SCAN INDICATOR should have 2 National Codes and a Default Code, see V3 at:

https://v3.datadictionary.nhs.uk/data_dictionary/attributes/b/brain_injury_detected_on_mri_scan_indicator_de.asp@shownav=1.html and https://v3.datadictionary.nhs.uk/data_dictionary/data_field_notes/b/br/brain_injury_detected_on_mri_scan_indicator_de.asp@shownav=1.html

V3+, see https://www.datadictionary.nhs.uk/attributes/brain_injury_detected_on_mri_scan_indicator.html and https://www.datadictionary.nhs.uk/data_elements/brain_injury_detected_on_mri_scan_indicator.html has:

Is this an issue with the ingest?

AngelaFaulding commented 2 months ago

James will investigate.

AngelaFaulding commented 2 months ago

Hi @jamesrwelch - I have found a couple of other items that have 2 National Code s and a Default Code and look OK:

Let me know if you need any more examples.

jamesrwelch commented 2 months ago

Sadly this may be an issue for Likin then - in the XML I receive, both ACTIVE COOLING INDICATOR and ADDITIONAL UNPLANNED PROCEDURE REQUIRED INDICATOR include <value-set> XML retrieved from the Terminology Server, but BRAIN INJURY DETECTED ON MRI SCAN INDICATOR doesn't include that xml content

AngelaFaulding commented 2 months ago

Hi @likin1 - please see the issue above and comment from James. Can you investigate please?

likin1 commented 1 month ago

the issue here is that the National codes have not been parsed: Look at the screenshot from v3+site. The codes are appearing as part of the description. @AngelaFaulding Can you edit this as part of next release. The National codes table has to be preceded by text "National Codes:". image

AngelaFaulding commented 1 month ago

Thanks @likin1 - I will fix for the next release.

AngelaFaulding commented 3 days ago

Looks OK in the test publication.