search

NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

CATEGORY VALUED PERSON OBSERVATION: PERSON PHYSICAL ACTIVITY LEVEL Class Relationship #546

Open AngelaFaulding opened 3 months ago

AngelaFaulding commented 3 months ago

@jamesrwelch - could you please have look at the CATEGORY VALUED PERSON OBSERVATION: PERSON PHYSICAL ACTIVITY LEVEL Class Relationship.

Why doesn't PERSON PHYSICAL ACTIVITY LEVEL in V3+ have "or" as it does in V3.

V3 has:

image

V3+ has:

image
AngelaFaulding commented 2 months ago

James to investigate. ACTIVITY also has or but I'm not sure if it is the same: https://www.datadictionary.nhs.uk/classes/activity.html Does this help?

jamesrwelch commented 2 months ago

The relationship to PERSON PHYSICAL ACTIVITY LEVEL is modelled slightly differently from all the others. In the XML, I'm seeing that relationship owned by that class, with relationClientExclusivity set to A. Whereas the other 24 relationships are owned by their respective target classes, with relationSupplierExclusivity set to A.

jamesrwelch commented 2 months ago

If this is the only occurrence that we've found, it might be quicker to change the relation in Together rather than me rewriting the ingest code to handle this.

AngelaFaulding commented 2 months ago

Thanks @jamesrwelch - I will try to make this relationship the same as the others.

AngelaFaulding commented 1 month ago

Relationships updated and will check in the next release.

AngelaFaulding commented 6 days ago

Looks OK in the test publication.