NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Error in Mauro: how do I know what to do? #548

Open AngelaFaulding opened 2 months ago

AngelaFaulding commented 2 months ago

I have tried to access the National Eye Colour Data Set in CR8000 - National Eye Colour Data Set Version 1 and received the following.

I can access the data groups.

How do I know what the issue is and how to fix it?

Will it display correctly in the Orchestrator and on the website? I can't test this, see #547 If I create new data groups will they be OK?

image

Not Found

We're sorry, but the server returned a 'Not Found' error

Details

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 404,
  "statusText": "OK",
  "url": "https://mauro.dev.dataproducts.nhs.uk/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for https://mauro.dev.dataproducts.nhs.uk/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14: 404 OK",
  "error": {
    "path": "/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14",
    "resource": "CodeSet",
    "id": "4e79dd11-4702-40ff-aba2-0eaad0fa9a14"
  }
}
AngelaFaulding commented 2 months ago

The data set does display in the Orchestrator but how to do I fix the issue?

pjmonks commented 2 months ago

I have run an integrity check on the CR8000 branch, which has produced no issues with broken links. And I can preview the "National Eye Colour Data Set Version 1" data set in the Orchestrator without issue.

Without a discrete set of steps to define what "access" the data set means, I do not see a reproducible bug so think this should be closed.

AngelaFaulding commented 2 months ago

Sorry @pjmonks - I don't agree. I am still getting the same error when clicking on the data set in Mauro.

image

Not Found

We're sorry, but the server returned a 'Not Found' error

Details

{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 404,
  "statusText": "OK",
  "url": "https://mauro.dev.dataproducts.nhs.uk/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for https://mauro.dev.dataproducts.nhs.uk/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14: 404 OK",
  "error": {
    "path": "/api/codeSets/4e79dd11-4702-40ff-aba2-0eaad0fa9a14",
    "resource": "CodeSet",
    "id": "4e79dd11-4702-40ff-aba2-0eaad0fa9a14"
  }
}
AngelaFaulding commented 2 months ago

Peter will investigate

pjmonks commented 2 months ago

I have fixed this problem manually for you. You can now view the "National Eye Colour Data Set" under "CR8000 > Data Sets > Clinical Data Sets > Colour Data Sets".

The cause was because one of the data types under the "National Eye Colour Data Set" was referencing a code set which no longer existed. I do not know how it got into this state, but the UI will try to fetch all linked code sets to display information under the "Data Type".

The incorrectly linked code set looked like should be linked to the code set "NHS NUMBER STATUS INDICATOR CODE", so I had to manually fix the data type in the database. The result is you can now view the data set in Mauro.

image

AngelaFaulding commented 2 months ago

I can now view the data set. It is concerning that these type of errors will be displayed and we don't know how to resolve it. This links to #564.