NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Retire a Term #556

Open AngelaFaulding opened 2 months ago

AngelaFaulding commented 2 months ago

Could you please explain how to retire a Term.

So far in the Test Branch I have retired code 3 of RADICAL PROSTATECTOMY MARGIN STATUS

image

I have checked the Orchestrator and nothing different is showing to before:

image

Retired items should display, for example as in: https://www.datadictionary.nhs.uk/data_elements/planned_cancer_treatment_type.html

image

The retired text in bracket is added by us. Where do we add it in Mauro?

Do we just ignore web presentation for this?

image

I have noticed that the item below has the text in the Definition field.

image

Is it the Definition field that we use for this?

AngelaFaulding commented 2 months ago

Peter thinks that if we add a date in the profile, that should display on the Orchestrator. He will look into this.

pjmonks commented 2 months ago

This issue has been fixed and deployed to TEST, TRAINING and LIVE. Please move this to the "Ready for NHS E Testing" state.

pjmonks commented 2 months ago

The fix was that marking a Term as retired now automatically adds text to the end of the name in the Orchestrator preview to say it is retired, and when. We have ingested a number of branches which have already saved this text to name of the Term, so if a Term already has a "(Retired dd MMM yyyy)" suffix, it will not be duplicated - you must remove it from the name before testing the "Is retired" checkbox.

AngelaFaulding commented 2 months ago

@pjmonks - I have created a new branch (CR8008) and retired the same items as above.

The retired text is displaying but the date isn't present. I have added a retired date to both terms but it does not display on the preview. How do we ensure the retired date is included as in the example I supplied above, i.e. https://www.datadictionary.nhs.uk/data_elements/planned_cancer_treatment_type.html which has the retied dates.

image

image

image

image

pjmonks commented 2 months ago

It is because the date you've entered is not in a format it was expecting, but the format it is expecting would be too confusing to use. I'll fix it:

AngelaFaulding commented 2 months ago

Ticket moved as Peter needs to fix this.

pjmonks commented 2 months ago

I have deployed a fix to TEST to correctly display the retired terms on the preview/DITA pages.

To retire a term in an Attribute Terminology:

  1. Select the term to edit.
  2. Select the "NHS Data Dictionary - Term" profile

image

  1. Click on "Edit", then tick "Is retired" and enter a date in the "Retired date" field e.g. "1 September 2024"

The text you enter for the retired date will appear exactly as you've written it, because it the field is not set to a date type.

Also note that a lot of terms have been ingested already and look like this:

image

If you are making a new term or changing term to now be retired, please follow my first set of instructions. However, because a lot of these ingested terms already exist, the "Retired" text for a term does not duplicate information - in these cases, the text on the item label takes precedence. If you want to change this:

  1. Change the "Retired date" field to a different text value that you want to display e.g. "1 April 2024"
  2. Remove the "Retired" text from the label.
  3. Now the preview/DITA for the term will match what I originally described.
AngelaFaulding commented 2 months ago

@pjmonks - I'm not sure what you mean as this is what I entered:

image

I have not touched the item you describe above, that code is retired in the live dictionary:

image

The item I updated is now showing as correct:

image

Can you please confirm that all existing retired codes will work OK if they are in the format which you say is not correct? You say we can change them, but there are so many we wouldn't want to do that.

Also, the Data Element is not displaying it's description. Is this linked to #381 ?

image
pjmonks commented 2 months ago

I will break down my response:

RADICAL PROSTATECTOMY MARGIN STATUS terms

I assume this was not retired before, but is now. This term has been newly retired correctly, because the retired date/status is not part of the label of the term itself, and the retired date is set by yourself - it will appear exactly as you've written it.

image

image

ABLATIVE THERAPY TYPE terms

I assume these terms were retired beforehand and ingested from Borland Together. This is why the retired date is written in a very precise format, but you probably don't want that date format to appear. This is why I think James has written the ingest process to put the date directly into the label of the term (or that was the label provided to us by your ingest file, I do not know ). Nonetheless, I've made sure that this appears in the same way as RADICAL PROSTATECTOMY MARGIN STATUS:

image

image

Conclusion

You do not have to change any previously retired terms. If you need to retire a new term going forward, follow the process you have done for RADICAL PROSTATECTOMY MARGIN STATUS.

Missing Description

I've checked why Data Element RADICAL PROSTATECTOMY MARGIN STATUS description is not appearing and it is quite simple - there is no description to display.

image

image

I do not know why there is no description, but it is ultimately a content issue that can easily fixed by yourselves.

KatePalmerLilley commented 2 months ago

The description issue appears to be #381

KatePalmerLilley commented 2 months ago

@AngelaFaulding Can we discuss what a retired term is supposed to look like in the new DD? In the Orch it correctly shows the retired date:

image

Is that all we expect now? I know in the old DD the text was greyed out.

Looking for an example I came across a bit of a mix https://www.datadictionary.nhs.uk/attributes/area_of_work_name.html

AngelaFaulding commented 1 month ago

@jamesrwelch - please see https://www.datadictionary.nhs.uk/attributes/cancer_treatment_intent.html. Is the DITA set up so all retired National Codes are shown in a grey row?

AngelaFaulding commented 1 month ago

This may not be good for accessibility. James will investigate.