NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Orchestrator Change Paper Preview showing too many changes #557

Open AngelaFaulding opened 2 months ago

AngelaFaulding commented 2 months ago

Peter as discussed, I removed this details from #525.

I didn't tick the "include data set definitions" box and these are the results for the Test Branch and CR8000.

They both have lots of extra content.

This extra content is not linked to the August 2024 release.

CR8000 - National Eye Colour Data Set Version 1.docx Test branch.docx

pjmonks commented 2 months ago

I have found the cause of the problem. Your branch and the latest released branch contain minor text differences in descriptions of items. This differences should not matter because they are just whitespace differences in the HTML content. As a cut down example, consider:

Your branch:

<p>This is a <a href="page.html">link</a>

Latest release branch:

<p>   This is a    <a href="page.html">link</a>

Browsers would consider this content to be the same because the content matches. The only difference is the additional whitespace, this is producing false positives.

I have created this issue for tracking:

AngelaFaulding commented 2 months ago

Thanks @pjmonks - we haven't touched the majority of the items so it is strange that this is happening.

pjmonks commented 2 months ago

This issue has been fixed and deployed to TEST, TRAINING and LIVE. Please move this to the "Ready for NHS E Testing" state.

pjmonks commented 2 months ago

To test, run through the scenario you originally described and check that the correct changes are now appearing.

AngelaFaulding commented 2 months ago

@KatePalmerLilley - I think this is now happening as the CRs we created have not been merged with the August release. Do we do this as a test of merging? CR8008 which I created today doesn't have extra content. It just has the data set issue, #551