NHSDigital / DataDictionaryPublication

Apache License 2.0
7 stars 1 forks source link

Duplicate items by changing the case type #595

Open KatePalmerLilley opened 1 month ago

KatePalmerLilley commented 1 month ago

During testing of #489 I discovered that duplicate items can be created by changing the capitalisation e.g.:

image

We believe the likelihood of creating a duplicate this way is higher for NHS Business Definitions, Supporting Information, XML Schema Constraints and Data Set Constraints as some are in title case and some are in CamelCase.

pjmonks commented 1 month ago

I'm afraid this is not a trivial request, the validation of labels of Mauro items is a key part of the Mauro core system. Currently, all labels must have some basic rules, such as:

Labels of models are more complicated, because they must be unique in Mauro with respect to:

  1. Model versions, if final
  2. Branch name, if not final

At the moment, having different casing in labels means they are technically unique, but I don't know if making that more restrictive would have further impact on Mauro itself. We would need to discuss with @jamesrwelch first, because this is a core system change that would need his ultimate approval anyway.

KatePalmerLilley commented 1 month ago

08/10/24 - James explained that this is core Mauro functionality and while we could submit a change request to the Mauro community it's like to be rejected. James suggested that we could look at an integrity check to pick up these types of dupes. @AngelaFaulding we will need to factor this into our business processes.

AngelaFaulding commented 1 month ago

@jamesrwelch - can we discuss having an integrity check for this please?

AngelaFaulding commented 1 month ago

15/10/24 - James will look into creating an integrity check for this. This is not required for migration.