search

NHSDigital / integration-adaptor-lab-results

Integration Adaptor to simplify processing of Pathology and Screening results
Apache License 2.0
0 stars 6 forks source link

While passing incorrect workflowID in environment variable is transforming edifact into FHIR #114

Closed sonalVarma closed 3 years ago

sonalVarma commented 3 years ago

Description When updating workflowID of pathology message PATH_MEDRPT_V3 in env.fake-mesh.sh , and sending an edifact for screening message , is transforming into FHIR

Steps to reproduce

  1. Update the workflow id for pathology message - export WORKFLOW_ID=PATH_MEDRPT_V3
  2. Send send_message.sh with - ./mesh.sh send C88062GP001 "@./../src/intTest/resources/success_uat_data/NHS004/screening_full_acceptance_with_nhsack.edifact.dat"

Actual result image Message_id is generated . While checking in azure service bus , message is available in gp_outbound_queue and edifact is transformed to corresponding FHIR JSON as well. Attached FHIR JSON -

FHIR.txt image

Expected result Error should be displayed when incorrect workflow ID is passed.

@michael-kainos @bartek-sarul

bartek-sarul commented 3 years ago

@sonalVarma Workflow IDs are to tell app and script from where to download / upload messages. At this moment there is no check to verify that interchange from a given workflow contains only matching messages. Is this something that breaks the ability to use the adaptor?

sonalVarma commented 3 years ago

@bartek-sarul the functionality of the adaptor didn't break with this. Just wanted to confirm about the verification of workflowID with that of messages.

bartek-sarul commented 3 years ago

@sonalVarma we've decided not to treat workflows as indicators of interchange content but only the source and target of data. Most important are the message indicators of each interchange message header. This way a single interchange can have 002, 003 and 004 at the same time which does not break any specification. If this is ok for you, please close this ticket