search

NHSDigital / integration-adaptor-lab-results

Integration Adaptor to simplify processing of Pathology and Screening results
Apache License 2.0
0 stars 6 forks source link

The INT sample NHS002 full_acceptance_withouth_nhsack.1.fhir.json have invalid timestamp format in the bundle meta last update #129

Closed Kusnaditjung closed 3 years ago

Kusnaditjung commented 3 years ago

Bugs The INT sample NHS002 full_acceptance_withouth_nhsack.1.fhir.json output invalid timestamp format '2010-02-26T15:41'. It missing second part

Step to reproduce

  1. check the above sample data
  2. Check Bundle, meta lastupdated, it is missing the second part.

Expected behavior It contains second part.

bartek-sarul commented 3 years ago

@Kusnaditjung I don't see Bundle.meta.lastUpdated anywhere without seconds part. Can you add a direct link to the place where it's missing?

Kusnaditjung commented 3 years ago

here is the link, https://github.com/nhsconnect/integration-adaptor-lab-results/blob/main/src/intTest/resources/success_uat_data/NHS002/full_acceptance_without_nhsack.1.fhir.json

Check Bundle => meta => lastUpdated

bartek-sarul commented 3 years ago

@Kusnaditjung I see in the latest version of this file it's correct: image but previous had it without seconds as you noticed image

I think the issue was that the file has been manually altered and automatic test ignored timestamp precision. The value is correct now but I'll update our test cases

ejudgemeddbase commented 3 years ago

RETEST 1

TEST STEPS TO REPRODUCE ISSUE Pathology2.txt

I re-ran request pathology_2 and reviewed the FHIR output.

ACTUAL RESULT

Pathology2FHIR.txt 129

I can see that the lastUpdated element now has a valid timestamp in the meta element.

Retest 1 PASSED

Defect 129 Closed