Specification Validation Error: MIssing Test result Observation 'related''s type(with value derived-from).

NHSDigital / integration-adaptor-lab-results

Integration Adaptor to simplify processing of Pathology and Screening results

Apache License 2.0

0 stars 6 forks source link

Specification Validation Error: MIssing Test result Observation 'related''s type(with value derived-from). #135

Closed Kusnaditjung closed 3 years ago

Kusnaditjung commented 3 years ago

Bugs Missing test result in observation 'related''s type (derived-from).

Step to reproduce check:

pathology_2.fhir.json
pathology_3.fhir.json
NHS002->full_acceptance_without_nhsack.1.fhir.json
NHS003-> All messages

Expected behaviour test result (Observation) related's type element must be populated if it refers to a test group.

bartek-sarul commented 3 years ago

Need NHS help

bartek-sarul commented 3 years ago

As NHS suggests, I'm removing the "up" link leaving only links from group to result

michael-kainos commented 3 years ago

Changed bi-directional reference between Observation and Specimen resources

Only Observation resources will contain reference to Specimen resources. There is now no Specimen resources which has a reference to Observation resources

jhoey-med commented 3 years ago

RETEST 1

TEST STEPS TO REPRODUCE ISSUE

Check the FHIR payloads of each of the below messages after sending their corresponding EDIFACT messages to the adaptor

pathology_2.fhir.json
pathology_3.fhir.json
NHS002->full_acceptance_without_nhsack.1.fhir.json

ACTUAL RESULT

Element 'type' is now present in each of the FHIR responses

Please see screenshots attached.

pathology3

pathology2

Retest 1 PASSED

Defect 135 Closed