NHSDigital / integration-adaptor-lab-results

Integration Adaptor to simplify processing of Pathology and Screening results
Apache License 2.0
0 stars 6 forks source link

FHIR field assignment error: EDIFACT delimiter get populated in the coded value display #152

Closed Kusnaditjung closed 3 years ago

Kusnaditjung commented 3 years ago

Bugs Some of the coded value population get mixed with the EDIFACT delimiter see example https://github.com/nhsconnect/integration-adaptor-lab-results/blob/main/src/intTest/resources/success_uat_data/NHS004/screening_full_acceptance_with_nhsack.1.fhir.json

in this text: { "system": "http://snomed.info/sct", "code": "368481000000103", "display": "BCS?:FOB result" }

Step to reproduce See example above

Expected behaviors delimiter character should not be populated.

jhoey-med commented 3 years ago

RETEST 1

TEST STEPS TO REPRODUCE ISSUE

Resend screening_full_acceptance_with_nhsack.edifact.dat and inspect FHIR response

ACTUAL RESULT

EDIFACT delimiter is not present in 'display' FHIR element.

Please see screenshots attached.

image

image

image

image

NHS004_screening_full_acceptance_with_nhsack.edifact.dat FHIR payload txt.txt

Retest 1 PASSED

Defect 152 Closed