Update ECR login command to use non-deprecated get-login-password

NHSDigital / integration-adaptor-lab-results

Integration Adaptor to simplify processing of Pathology and Screening results

Apache License 2.0

0 stars 6 forks source link

Closed adrianclay closed 3 months ago

adrianclay commented 3 months ago

get-login is deprecated

These are items (excluding GitHub Checks) which should be confirmed before a branch is ready to merge.

[ ] Acceptance Criteria met
[x] Commit messages are meaningful
[ ] Manually tested
[x] Self-reviewed your code
[ ] Code reviewed from two other developers
[ ] If your pull request depends on any other, please link them in the description
[x] main branch is passing/green on CI
[ ] Add/update any relevant documentation

martin-nhs commented 3 months ago

Just an aside, if the PR quality checks aren't something that is cared about - wouldn't it make sense to just remove these? 😄

adrianclay commented 3 months ago

Just an aside, if the PR quality checks aren't something that is cared about - wouldn't it make sense to just remove these? 😄

Agreed, and if it weren't for the fact this repo gets 1 commit every 6 months, I would be more motivated to invest the time into looking into it. 😓