NHSDigital / integration-adaptor-nhais

Adaptors which accelerate integration with national NHS systems
Apache License 2.0
4 stars 3 forks source link

Inconsistency around "system" in notes and also Patient's Responsible HA (Sending HA Cipher) #224

Closed Kusnaditjung closed 4 years ago

Kusnaditjung commented 4 years ago

in the INBOUND.md documentation about the specification.

(1) The overall map, the FP69 Flag Removal, and Deduction reduction request, there is a row for Patient's Responsible HA (Sending HA Cipher), but in the section level, the wording is changed to 'Destinaton HA Cipher'. It seems to convey a slightly altered meaning. I just wonder there is a better way to document this in the overview, e.g put it in separate rows under different field, or if it collapsed under one field, it should be put (sending HA Cipher/ Destination (or new) HA Cipher).

(2) there note for 'system' for some of the message (Approval, Rejection, FP69 Prior Notification), but it is omitted for others. It will be better to be provided for other messages as well, for consistency and completeness, otherwise it can send a wrong message that this field is not required (e.g for validation)