Code review completed. - Githubissues

NHSDigital / ndr_error

Error logging Rails engine

MIT License

1 stars 3 forks source link

Code review completed. #1

Closed miles-smith closed 8 years ago

miles-smith commented 8 years ago

I've sanity checked the files but I think there are a couple of things that probably warrant discussion before marking them as 'safe'.

timgentry commented 8 years ago

Could you take a look at why tests are failing in the presence of a code_safety file (under Rails 4.2)?

joshpencheon commented 8 years ago

@miles-smith, do you want to try rebasing your branch against a2ca5b2? I was able to reproduce the issue locally, although I'm not sure why it hasn't failed before...

joshpencheon commented 8 years ago

Comparing the output of:

https://s3.amazonaws.com/archive.travis-ci.org/jobs/95770807/log.txt https://s3.amazonaws.com/archive.travis-ci.org/jobs/101599376/log.txt

The build started failing once sprocket-rails v3 was pulled in via bundle update.