search

NHSDigital / ndr_support

National Disease Registers support gem
MIT License
4 stars 6 forks source link

Partition / Deprecate / Remove legacy logic from NdrSupport #3

Open joshpencheon opened 8 years ago

joshpencheon commented 8 years ago

Some of the code in NdrSupport was extracted from legacy systems. It would not always be desirable to add this blindly to other projects.

Some of this logic has been encapsulated (e.g. NdrSupport.attempt_date_patch!), but in the current release is still active-by-default.

We should list methods that are undesirable (resp. unused by internal NDR projects!?), and put them through a deprecation cycle, after which they would be disabled-by-default (resp. removed entirely).

@timgentry, does this sound sensible?

timgentry commented 8 years ago

Definitely. Now that we have https://github.com/PublicHealthEngland/ndr_dev_support, I'm going to try and not use any of NdrSupport directly within our two new projects.

It's important to identify what https://github.com/PublicHealthEngland/ndr_import and our other gems use of it. Should RegexpRange move to NdrImport for example?