search

NHSDigital / ndr_support

National Disease Registers support gem
MIT License
4 stars 6 forks source link

Keep list of Bank Holidays up to date #8

Open joshpencheon opened 6 years ago

joshpencheon commented 6 years ago

The WorkingDays concerns tracks public holidays (for England/Wales), but needs manual updating. As a result, it has fallen stale.

We should make use of https://www.gov.uk/bank-holidays/england-and-wales.json, perhaps baking the cache at rake build time. We can't presume to have internet connectivity once ndr_support is being used.

timgentry commented 5 years ago

@joshpencheon regardless of the solution, we could add a test that goes and gets https://www.gov.uk/bank-holidays/england-and-wales.json and assert that all the returned bank holidays are considered holidays.

timgentry commented 5 years ago

If we did use the holidays gem I think we would use the :gb_eaw region