Failing link check

[regularfry]

Just a sanity check to see what the behaviour of the link checker is around redirects.

[regularfry]

Setting "ready for review" to get the markdown link checker action to run. Don't worry about reviewing.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[regularfry]

Ok, so this has passed. Looking through the dependency stack I couldn't see anything obviously wrong about the way timeouts are handled, but replacing redirected links with their eventual destination means fewer network requests, so fewer opportunities to go wrong. The increased timeout also means that if we are getting rate-limited at the other end, we're less likely to see a failure as a result.

[andyblundell]

Ah is there a timeout setting on this action - it does throw a few false negatives, which are a nuisance

[regularfry]

Ah is there a timeout setting on this action - it does throw a few false negatives, which are a nuisance

Yeah, I've changed it to 30 seconds. It defaults to 10. I'm unclear what would fail at 10 seconds but pass at 30. It just doesn't seem like a very natural breakpoint unless we're getting rate limited somewhere.

[sonarcloud[bot]]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[walteck]

These updates have made it into main through other branches - I'd propose that we close this PR and branch. @regularfry - any objection?

[regularfry]

Agreed.