Update consent: Structural issue - Missing NHS number value is giving 500 internal server error

[sonalVarma]

Describe the bug The nhs number value is required in payload. If we are not passing it , then it is giving 500 internal server error "part": [ { "name": "nhsNumber", "valueString": "9693044479" }, { "name": "permissionCode",

To Reproduce Attached request - Missing nhs number value field.txt

Expected behavior This can be treated as structural/syntax issue and should give invalid response possibly, 400 - Bad request.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Version: [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser: [e.g. stock browser, safari]
• Version: [e.g. 22]

@michael-kainos @dawidskainos

[dawidskainos]

Will add a fix in next release version

[dawidskainos]

Will be fixed in https://gpitbjss.atlassian.net/browse/NIAD-1209

[dawidskainos]

Deployed to INT and ready for re-test.

[sonalVarma]

@dawidskainos , The issue is fixed now. The response code received is 400 - Bad request with response body - { "resourceType": "OperationOutcome", "issue": [ { "severity": "error", "code": "value", "details": { "text": "Parameter.Part named 'nhsNumber' with not empty value not found" } } ] }

Can you please once check the error text message . with not empty value not found

[dawidskainos]

@sonalVarma I changed the error message. I hope it makes more sense now. Ready for retest.

[sonalVarma]

{ "resourceType": "OperationOutcome", "issue": [ { "severity": "error", "code": "value", "details": { "text": "Missing value for Parameter.Part 'nhsNumber'" } } ] }