NHSDigital / terraform-aws-mesh-client

Reference implementation of a MESH Client in an AWS environment only using serverless technologies.
MIT License
1 stars 1 forks source link

Parameter store references are statically typed #119

Open aidenvaines-bjss opened 7 months ago

aidenvaines-bjss commented 7 months ago

Under EM-822 we are looking to put an alarm on certificate expiry and we noticed the SSM parameters are statically typed. `data "aws_ssm_parameter" "ca_cert" { name = "/${local.name}/mesh/MESH_CA_CERT" }

moved { from = aws_ssm_parameter.ca_cert to = data.aws_ssm_parameter.ca_cert }`

These data resources are statically typed and are expecting the user of this module to have created the parameters with that exact name which could be undesired or dangerous. This should probably be a variable in the module the user is expected to declare, perhaps this mechanism could be fallback or default logic?