NHSLeadership / nightingale-2-0

A WordPress theme for the NHS using the NHS.UK frontend library
Other
28 stars 15 forks source link

Alignment issue with responsive menu button #573

Closed CastorUK closed 1 year ago

CastorUK commented 1 year ago

Describe the bug The responsive menu button in mobile view is pushing out to the right.

To Reproduce Steps to reproduce the behavior:

  1. View a website using the theme on a mobile browser or desktop responsive view
  2. Verify the MENU button the header is aligned incorrectly, and pushes the browser window to the right

Expected behavior In mobile view, MENU button should align correctly, and does not extend the browser to the right.

Additional context The issues appear to come from header.scss line 65.

.nhsuk-header { &.nhsuk-header--transactional { .nhsuk-header__menu-toggle { position: absolute; @include mq($until: tablet) { top: auto; } @include mq($from: tablet) { left: -76px; }
} }

position: absolute; is overriding...

.nhsuk-header__menu { position: relative; }

maheshmuralip commented 1 year ago

Thanks @CastorUK We will be looking into this soon.

maheshmuralip commented 1 year ago

Thanks @CastorUK The issue with the button header which aligned incorrectly, and pushes the browser window to the right might have fixed by one of previous releases. Let me close this issue, and if encountered any similar issue please create a new one.

CastorUK commented 1 year ago

Hi @maheshmuralip

I'm still experiencing the issue. Theme version 2.4.12.

maheshmuralip commented 1 year ago

Hi @CastorUK,

Could you please let me know the any settings that you are using or any additional CSS? Also, if possible could you please share any link of the page having the issue?

Many thanks.

CastorUK commented 1 year ago

Hi @maheshmuralip

Here's an out-the-box test site I've setup. https://surveytest.necsu.info.

It's using the theme with no customisations or additional css. It is using NHS Blocks and Nightingale Companion.

Theme setting are:

Nightingale Companion: default other disabled style login

maheshmuralip commented 1 year ago

Thanks @CastorUK for the details.

maheshmuralip commented 1 year ago

@CastorUK A fix has been added in the latest version. Thanks