NHSLeadership / nightingale-2-0

A WordPress theme for the NHS using the NHS.UK frontend library
Other
28 stars 15 forks source link

Remove closing tag #587

Closed SavPhill closed 1 year ago

SavPhill commented 1 year ago

The page.php template includes a closing tag at the end of the file.

It is suggested that the closing tag ?> be omited from the end of php files so unwanted whitespace will not occur at the end of file, and you will still be able to add headers to the response later. It is also more consistent as the other page templates omit the closing tag.

Fixes #588

See official references supporting this change:

PSR-2 PHP.net

maheshmuralip commented 1 year ago

Thanks @SavPhill