search

NHSLeadership / nightingale

NHS-Generic Frontend Framework.
Other
35 stars 8 forks source link

IE8 Fixes #136

Closed csswizardry closed 7 years ago

csswizardry commented 7 years ago

For the most part, IE8 looks really respectable! There are some cosmetic issues remaining that we should discuss (i.e. is it going to be financially viable to fix everything) and a couple of leftovers that I expect to be fixed as part of other tasks.

csswizardry commented 7 years ago

@cehwitham: There shouldn’t be any ::hover specifically, as that’s never been a thing. Did you see ::hover or was that a typo? To answer the question more generally, please see ffb2d522e 👍

cehwitham commented 7 years ago

I saw ::hover ::beforehad been removed in a lot of places but I think it's answered by:

OldIE doesn’t support the ::(before|after) double-colon syntax. Dropping back to single colons seems to fix, well, a lot!

As you said.

csswizardry commented 7 years ago

I think/hope you’ve seen ::before and ::after, and not ::hover, though. If there are any ::hovers in there, it’s a typo!

Edit: Just checked. I think it’s just a persistent typo on your part haha. There were/are no double-colon ::hover pseudos :)