search

NHSLeadership / nightingale

NHS-Generic Frontend Framework.
Other
35 stars 8 forks source link

innerWidth isn't supported in IE8 #142

Open chriscoffee opened 7 years ago

chriscoffee commented 7 years ago

We use innerWith to check if width is below 720 to serve the mobile menu. This isn't supported in IE8 and we'll need to use some logic to do document.documentElement.clientWidth || document.body.clientWidth or similar.

penpadstudio commented 6 years ago

@csswizardry @cehwitham Do we know if this has been implemented?

cehwitham commented 6 years ago

I don't believe so. But not sure how much effort we need to put into IE8.

Also, IE8 is hardly going to be using responsive windows and phone screens.

Could you look at Analytics @Pro-Paul and see what usage is like please?

penpadstudio commented 6 years ago

We should drop the concern for IE 8 see attached reports for last 30 days and last 6 months. Most users are upgraded to IE11 surprisingly!

Analytics NHS Leadership Academy Browser & OS 20180610-20180709.pdf Analytics NHS Leadership Academy Browser & OS 20171210-20180709.pdf

penpadstudio commented 6 years ago

@cehwitham if you agree please go ahead and close all IE8 issues. thx