NHSLeadership / nightingale

NHS-Generic Frontend Framework.
Other
35 stars 8 forks source link

Panels #161

Open penpadstudio opened 7 years ago

penpadstudio commented 7 years ago
screen shot 2017-09-08 at 11 23 05

@cehwitham set priority please.

cehwitham commented 7 years ago

@Pro-Paul is this an improvement on or a replacement for #97 ?

Is it additional work on top of #119 ?

penpadstudio commented 7 years ago

These are panels (cards) completely different to media items that can be placed inside of panels.

cehwitham commented 7 years ago

@Pro-Paul #97 and #119 both talk about Panels not media though?

penpadstudio commented 7 years ago

mix of language, A media component is the e.g. a slider, image, video. A Panel is a module of of e.g. slider, image, video with buttons, bounding box etc

penpadstudio commented 7 years ago

Take a look at the wiki, I am building the design hierarchy of modules etc. so its easier to understand

cehwitham commented 7 years ago

@Pro-Paul so for the most part this should just be putting everything together rather than building lots of new stuff?

penpadstudio commented 7 years ago

If I understand you correctly then yes.

Android63 commented 6 years ago

Is it safe to say then that nothing needs to be added to the Nightingale framework @Pro-Paul?

penpadstudio commented 6 years ago

@Android63 can you be more specific please.

Android63 commented 6 years ago

I'm wondering if we need any new components in the Nightingale framework to address this issue. It seems that we probably don't since it's a case of using existing components.

penpadstudio commented 6 years ago

All components and elements are already in the framework for the panels, correct.

Android63 commented 6 years ago

OK thanks @Pro-Paul. In that case I'll unassign Harry since this doesn't need any CSS wizardry.

penpadstudio commented 6 years ago

@Android63 @cehwitham these are now being called cards (not Panels) and we have the card outline but they are not set up with media elements inside on the build.

cehwitham commented 6 years ago

@Pro-Paul so do we just need to add to the example page?

penpadstudio commented 6 years ago

@cehwitham yes, just need to implement them