search

NHSLeadership / nightingale

NHS-Generic Frontend Framework.
Other
35 stars 8 forks source link

Browser-support messaging for OldIE and non-JS #193

Open csswizardry opened 6 years ago

csswizardry commented 6 years ago

Can we look at adding banners for OldIE users (prompting them to upgrade), and a noscript message for users who’ve disabled JS (warning them about missing functionality)?

Android63 commented 6 years ago

How about we show the noscript ribbon by default but run a JS script to hide it? That way, it will remain if JS is disabled. My slight concern here is that it might flash up momentarily.

penpadstudio commented 6 years ago

@csswizardry @Android63 @cehwitham was this adhered for? If not we can use browser default until we have done our basic checks for Nightingale and move onto next iterations.

cehwitham commented 6 years ago

I don't believe this has been implemented yet @Pro-Paul

penpadstudio commented 6 years ago

@cehwitham is messaging something we need for Nightingale at this point anyway?

csswizardry commented 6 years ago

All we need to do is take an existing message component and wrap it in either <noscript> tags or a conditional comment (<!--[if lte IE 8]>). This is going to be really trivial to implement, we just need to Do It™.